refactor!: Rename some accesskit and accesskit_consumer types#734
refactor!: Rename some accesskit and accesskit_consumer types#734PoignardAzur wants to merge 5 commits into
Conversation
DataTriny
left a comment
There was a problem hiding this comment.
Please fix the intra doc links in the accesskit crate. We're clearly missing a CI check here.
accesskit::Tree is such a core type that I would prefer keeping it around for a few versions, but as a type alias:
#[deprecated]
pub type Tree = TreeInfo;Any opinion on replacing the type name by Self on impl blocks?
I haven't reviewed everything yet.
I think it could be a follow-up PR; mostly it would add even more noise. |
Rename accesskit::Tree to TreeInfo Rename accesskit_consumer::Node to accesskit_consumer::NodeRef Rename accesskit_consumer::NodeId to FullNodeId Rename accesskit_consumer::State to TreeState Because the previous names were ambiguous or had collisions, a lot of files imported them with aliases. This PR removes most of these alias imports. This is a rename-only PR with no behavior changes; most changes were done with rust-analyzer's "rename symbol" assist and similar (non-AI) tools.
e2fb955 to
6877422
Compare
|
I've made the requested changes. I looked into splitting this PR into several smaller PRs, but I don't think it's practical (a lot of the renames affect overlapping lines). |
|
@PoignardAzur Some of the CI jobs fail because you need to rebase and rename more stuff in the adapters. |
|
I've fixed the Windows build failures, but I think the cargo-deny errors are unrelated to this PR? |
Closes #720
Rename accesskit::Tree to TreeInfo
Rename accesskit_consumer::Node to accesskit_consumer::NodeRef Rename accesskit_consumer::NodeId to FullNodeId
Rename accesskit_consumer::State to TreeState
Because the previous names were ambiguous or had collisions, a lot of files imported them with aliases.
This PR removes most of these alias imports.
This is a rename-only PR with no behavior changes; most changes were done with rust-analyzer's "rename symbol" assist and similar (non-AI) tools.