docs: add code examples for Textarea, Timepicker, Tag, Switch#755
Open
fateeand wants to merge 1 commit into
Open
docs: add code examples for Textarea, Timepicker, Tag, Switch#755fateeand wants to merge 1 commit into
fateeand wants to merge 1 commit into
Conversation
fateeand
requested review from
TerranceKhumalo-absa,
korel-san and
lukasmatta
as code owners
July 17, 2026 14:19
Contributor
Coverage report for library
Test suite run success2386 tests passing in 76 suites. Report generated by 🧪jest coverage report action from 9d1db75 |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enhances the Composition app’s documentation pages for Textarea, Timepicker, Tag, and Switch by adding live, copyable code examples via the existing CodeExampleComponent, and centralizing the example source strings in new *.examples.ts files (closing #738, #741, #742, #743).
Changes:
- Added new
*.examples.tsfiles to store HTML/TS snippet strings for each component page. - Updated each page template to wrap each demo in
<app-code-example>and wirehtmlCode/tsCodeinputs to the new examples map. - Removed now-unneeded “group” wrapper styles/classes (spacing is handled by
CodeExampleComponent).
Reviewed changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| projects/composition/src/app/pages/timepicker-page/timepicker-page.examples.ts | Adds timepicker example HTML/TS snippet definitions. |
| projects/composition/src/app/pages/timepicker-page/timepicker-page.component.ts | Imports CodeExampleComponent and exposes examples for template binding. |
| projects/composition/src/app/pages/timepicker-page/timepicker-page.component.html | Wraps each timepicker demo in <app-code-example> and binds snippet strings. |
| projects/composition/src/app/pages/timepicker-page/timepicker-page.component.scss | Removes obsolete .timepickers-group styling. |
| projects/composition/src/app/pages/textarea-page/textarea-page.examples.ts | Adds textarea example HTML/TS snippet definitions. |
| projects/composition/src/app/pages/textarea-page/textarea-page.component.ts | Imports CodeExampleComponent and exposes examples for template binding. |
| projects/composition/src/app/pages/textarea-page/textarea-page.component.html | Wraps each textarea demo in <app-code-example> and binds snippet strings. |
| projects/composition/src/app/pages/textarea-page/textarea-page.component.scss | Removes obsolete .textarea-group styling. |
| projects/composition/src/app/pages/tag-page/tag-page.examples.ts | Adds tag example HTML/TS snippet definitions. |
| projects/composition/src/app/pages/tag-page/tag-page.component.ts | Imports CodeExampleComponent and exposes examples for template binding. |
| projects/composition/src/app/pages/tag-page/tag-page.component.html | Wraps each tag demo in <app-code-example> and binds snippet strings. |
| projects/composition/src/app/pages/tag-page/tag-page.component.scss | Removes obsolete .tags-group styling. |
| projects/composition/src/app/pages/switch-page/switch-page.examples.ts | Adds switch example HTML/TS snippet definitions. |
| projects/composition/src/app/pages/switch-page/switch-page.component.ts | Imports CodeExampleComponent and exposes examples for template binding. |
| projects/composition/src/app/pages/switch-page/switch-page.component.html | Wraps each switch demo in <app-code-example> and binds snippet strings. |
| projects/composition/src/app/pages/switch-page/switch-page.component.scss | Removes obsolete .switches-group styling. |
Contributor
Playwright test resultsDetails
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds live code examples to the Textarea, Timepicker, Tag and Switch components' documentation pages.
Closes #741
Closes #742
Closes #743
Closes #738