Skip to content

fix(core): oneOf wrapper (externally-tagged) unions generate an internally-tagged model that cannot deserialize the wire payload#105

Merged
mfabisiak merged 3 commits into
masterfrom
fix/104-oneOf-wrapper-unions-generate-an-internally-tagged-model-that-cannot-deserialize-the-wire-payload
Jul 8, 2026
Merged

fix(core): oneOf wrapper (externally-tagged) unions generate an internally-tagged model that cannot deserialize the wire payload#105
mfabisiak merged 3 commits into
masterfrom
fix/104-oneOf-wrapper-unions-generate-an-internally-tagged-model-that-cannot-deserialize-the-wire-payload

Conversation

@mfabisiak

@mfabisiak mfabisiak commented Jul 8, 2026

Copy link
Copy Markdown
Member

closes: #104

Copilot AI review requested due to automatic review settings July 8, 2026 10:28
Copilot AI reviewed Jul 8, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@mfabisiak
mfabisiak requested a review from janwawszczak July 8, 2026 10:29
@github-actions

github-actions Bot commented Jul 8, 2026 •
edited
Loading

Copy link
Copy Markdown

Coverage Report

Overall Project 96.55% -0.12% 🍏
Files changed 97.22% 🍏

File Coverage
Names.kt 100% 🍏
ApiSpec.kt 100% 🍏
SerializersModuleGenerator.kt 100% 🍏
Hierarchy.kt 99.16% 🍏
ModelGenerator.kt 96.24% -0.63% 🍏
SpecParser.kt 94.7% 🍏

janwawszczak
janwawszczak requested changes Jul 8, 2026
View reviewed changes
Comment thread core/src/main/kotlin/com/avsystem/justworks/core/gen/model/ModelGenerator.kt
Comment thread plugin/src/functionalTest/kotlin/com/avsystem/justworks/gradle/JustworksPluginFunctionalTest.kt
Comment thread core/src/test/kotlin/com/avsystem/justworks/core/gen/ModelGeneratorPolymorphicTest.kt
@mfabisiak
mfabisiak requested a review from janwawszczak July 8, 2026 13:52
janwawszczak
janwawszczak approved these changes Jul 8, 2026
View reviewed changes

@janwawszczak janwawszczak left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for commitment in justworks :)

@mfabisiak
mfabisiak merged commit 9b33159 into master Jul 8, 2026
1 check passed
@mfabisiak
mfabisiak deleted the fix/104-oneOf-wrapper-unions-generate-an-internally-tagged-model-that-cannot-deserialize-the-wire-payload branch July 8, 2026 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments
@janwawszczak janwawszczak janwawszczak approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

oneOf wrapper (externally-tagged) unions generate an internally-tagged model that cannot deserialize the wire payload

3 participants

@mfabisiak @janwawszczak