Network: Fix TCP socket reset after timeout recovery (#157) - #161
Open
furbanc wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the Network component to v8.3.1 and fixes a TCP timeout-recovery edge case where the timeout-recovery flag could remain set after all unacked data has been acknowledged, potentially contributing to a socket reset after recovery.
Changes:
- Clear
TCP_IFLAG_TIMEOUTwhen the unacked queue becomes empty during ACK processing. - Bump Network component version from 8.3.0 to 8.3.1 across pack metadata, headers, and component viewer files.
- Add 8.3.1 entries to Network and General revision history docs.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| Keil.MDK-Middleware.pdsc | Updates dev release notes and Network bundle version to 8.3.1. |
| Documentation/Doxygen/Network/src/revision_history.md | Adds Network revision-history entry for v8.3.1. |
| Documentation/Doxygen/General/src/revision_history.md | Adds overall revision-history entry referencing Network 8.3.1. |
| Components/Network/Source/net_tcp.c | Clears timeout-recovery flag when unacked queue becomes empty after ACK processing. |
| Components/Network/Network.scvd | Updates component viewer version to 8.3.1. |
| Components/Network/Include/rl_net.h | Bumps Network patch version macro to 1 (8.3.1). |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.