Remove ignoreGainMap param of avifImageCreateView#3292
Merged
wantehchang merged 1 commit intoJul 2, 2026
Merged
Conversation
Remove the ignoreGainMap parameter of the avifImageCreateView() function. All the callers of avifImageCreateView() pass ignoreGainMap=false to the function. (The only exception is the recursive call on the gain map image, but the gain map image cannot have its own gain map image, so it doesn't really matter.)
maryla-uc
approved these changes
Jul 2, 2026
wantehchang
commented
Jul 2, 2026
| // a view of the original gain map. | ||
| // 'dstImage' should be an empty image. It will not own the pixel data. | ||
| avifResult avifImageCreateView(avifImage * dstImage, const avifImage * srcImage, avifBool ignoreColorProfile, avifBool ignoreAlpha, avifBool ignoreGainMap); | ||
| avifResult avifImageCreateView(avifImage * dstImage, const avifImage * srcImage, avifBool ignoreColorProfile, avifBool ignoreAlpha); |
Member
Author
There was a problem hiding this comment.
This PR is the first of a series of PRs.
The three ignore* parameters can be removed from `avifImageCreateView(). I am removing them in three steps.
ignoreGainMapis the easiest to remove.ignoreColorProfilewill be removed in Add the ignoreICC option to avifDecoder #3280. That PR is also simple.ignoreAlphawill be removed in Support ignoring alpha in imageContentToDecode #3288. That PR is more complicated, so I save it for the last.
After all this is done, we will be able to remove some of the avifImageCreateView() calls.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the ignoreGainMap parameter of the avifImageCreateView() function.
All the callers of avifImageCreateView() pass ignoreGainMap=false to the function. (The only exception is the recursive call on the gain map image, but the gain map image cannot have its own gain map image, so it doesn't really matter.)