Fix UB in SpiralIterator::operator++#481
Merged
Merged
Conversation
Collaborator
Author
|
Merge blocked by #482 |
Collaborator
|
@Ryanf55 rebase, please. |
* Calling pop_back on an iterator past the end is UB Signed-off-by: Ryan Friedman <25047695+Ryanf55@users.noreply.github.com>
Ryanf55
force-pushed
the
hotfix-spiral-iterator-ub
branch
from
78b5ceb to
d215049
Compare
wep21
approved these changes
Nov 28, 2024
Collaborator
Author
|
@Mergifyio backport jazzy |
✅ Backports have been createdDetails
|
mergify Bot
pushed a commit
that referenced
this pull request
Nov 28, 2024
* Calling pop_back on an iterator past the end is UB Signed-off-by: Ryan Friedman <25047695+Ryanf55@users.noreply.github.com> (cherry picked from commit 74dbbc8)
Collaborator
Author
|
https://github.com/Mergifyio backport iron |
✅ Backports have been createdDetails
|
mergify Bot
pushed a commit
that referenced
this pull request
Nov 28, 2024
* Calling pop_back on an iterator past the end is UB Signed-off-by: Ryan Friedman <25047695+Ryanf55@users.noreply.github.com> (cherry picked from commit 74dbbc8)
Collaborator
Author
|
@Mergifyio backport humble |
✅ Backports have been createdDetails
|
mergify Bot
pushed a commit
that referenced
this pull request
Nov 28, 2024
* Calling pop_back on an iterator past the end is UB Signed-off-by: Ryan Friedman <25047695+Ryanf55@users.noreply.github.com> (cherry picked from commit 74dbbc8)
Ryanf55
added a commit
that referenced
this pull request
Nov 28, 2024
Ryanf55
added a commit
that referenced
this pull request
Nov 28, 2024
Ryanf55
added a commit
that referenced
this pull request
Nov 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Forward port of #479 to fix undefined behavior