Skip to content

CI: Run CI tests on stable deps in Docker image pipelines and explicitly name test jobs - #4848

Draft
SurbhiJainUSC wants to merge 1 commit into
mainfrom
nightly_pipeline
Draft

CI: Run CI tests on stable deps in Docker image pipelines and explicitly name test jobs#4848
SurbhiJainUSC wants to merge 1 commit into
mainfrom
nightly_pipeline

Conversation

@SurbhiJainUSC

@SurbhiJainUSC SurbhiJainUSC commented Aug 12, 2026

Copy link
Copy Markdown
Collaborator

Description

This PR updates the nightly Docker image workflows to run CI tests on stable dependencies, relocates the Docker image promotion step, expands the CPU test suite, and improves the GitHub Actions UI by explicitly naming test jobs.

Specifically, this change:

  • Refactors test execution: Removes the run_tests input and the integrated run_ci_tests job from the shared .github/workflows/build_and_push_docker_image.yml workflow. Test execution is now explicitly handled by caller workflows.
  • Updates GPU & TPU pipelines:
    • Adds a new run_ci_tests job to .github/workflows/gpu_nightly_images_pipeline.yml to run Pre-Training CI tests against the maxtext_gpu_jax_stable image.
    • Simplifies the test matrix in .github/workflows/tpu_nightly_images_pipeline.yml by testing on maxtext_jax_stable (Pre-Training) and maxtext_post_training_nightly (Post-Training).
  • Relocates image tagging: Moves the tag_docker_image job out of the TPU nightly pipeline and directly into .github/workflows/run_ci_tests.yml. This ensures that images are only tagged as verified-${GITHUB_RUN_ID} and latest if they successfully pass the test suite.
  • Expands CPU testing: Adds cpu-integration tests to .github/workflows/run_tests_coordinator.yml and .github/workflows/ci_pipeline.yml.
  • Improves GitHub Actions UI: Adds explicit name: attributes to jobs across multiple workflows (e.g., build_package.yml, ci_pipeline.yml, check_docs_build.yml, docs_link_check.yml, etc.) to make the pipeline UI easier to read.

Tests

TPU nightly Docker image pipeline: https://github.com/AI-Hypercomputer/maxtext/actions/runs/31567082881

Checklist

Before submitting this PR, please make sure (put X in square brackets):

  • I have performed a self-review of my code. For an optional AI review, add the gemini-review label.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have run end-to-end tests tests and provided workload links above if applicable.
  • I have made or will make corresponding changes to the doc if needed, including adding new documentation pages to the relevant Table of Contents (toctree directive) as explained in our documentation.

@gemini-code-assist

Copy link
Copy Markdown

Note

Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported.

@SurbhiJainUSC SurbhiJainUSC changed the title CI: Run CI tests on stable deps in Docker image pipelines and explici… CI: Run CI tests on stable deps in Docker image pipelines and explicitly name test jobs Aug 12, 2026
@codecov

codecov Bot commented Aug 12, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@SurbhiJainUSC
SurbhiJainUSC force-pushed the nightly_pipeline branch 5 times, most recently from ea282c8 to a67c35c Compare August 12, 2026 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant