[DO NOT MERGE] Feat/nnx set defaults true g3 test#4146
Open
ecnal-cienet wants to merge 1 commit into
Open
Conversation
ecnal-cienet
changed the title
The PR6-PR10 sequence promoted every routed-to-Linen feature to NNX-native (DPO/PR6, MaxEngine/PR7, LoRA+GRPO/PR8, QK-Clip + checkpoint utilities/PR9, AQT + serve-mode/PR9.5, vocab tiling custom_vjp/PR10). With those gaps closed, NNX is the production path; this commit makes it the default. Empirical break-test on CPU (pytest before/after the flip across tiling_test, train_compile_test, sharding_compare_test, maxtext_utils_test, maxengine_test) showed zero flip-induced failures - every CPU unit-test failure pre-existed on PR10 tip. TPU smoke verified end-to-end: gemma2-2b 3-step train under the new defaults logged "pure_nnx: True" in pyconfig and produced loss 13.04 -> 12.32 -> 11.82 (decreasing, no NaN/inf, no Traceback). Linen-only test files were already pinned in the prior commit so no per-test breakage from the flip. base.yml: enable_nnx, pure_nnx_decoder, pure_nnx all flip False -> True. No use_nnx_pipeline flag is added: PR10 tip has no NNX pipeline path to opt out of, so a one-valued flag would be dead weight. Pipeline tests keep their Linen pin from the prior commit; the eventual NNX pipeline work (PR11.5) will introduce its own opt-in if needed. Sharding goldens not regenerated: tests/unit/sharding_compare_test.py already pins enable_nnx=False, pure_nnx=False, pure_nnx_decoder=False explicitly when invoking the dump utility, so existing goldens at tests/utils/sharding_info/ stay valid against the flipped default.
ecnal-cienet
force-pushed
the
feat/nnx-set-defaults-true-g3-test
branch
from
b6622f3 to
152195e
Compare
ecnal-cienet
requested review from
A9isha,
Lumosis,
NicoGrande,
NuojCheng,
RissyRan,
SurbhiJainUSC,
abhinavclemson,
aireenmei,
bvandermoon,
gagika,
gobbleturk,
gpolovets1,
hengtaoguo,
jesselu-google,
jiangjy1982,
jrplatin,
khatwanimohit,
mailvijayasingh,
mitalisi,
parambole,
patemotter,
richjames0,
shralex,
shuningjin,
suexu1025 and
vipannalla
as code owners
ecnal-cienet
requested review from
darisoy,
dipannita08 and
igorts-git
as code owners
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR is used for testing Google internal G3 tests.
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.