Disable group offset for tokamax gmm#4143
Open
NuojCheng wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
d722d04 to
d1f4d33
Compare
d1f4d33 to
8b3c7e0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes
use_tokamax_gmm=truecode path whenuse_ring_of_expert=false. It also adds an tokamax gmm AOT test.Tests
CI tests and tokamax gmm AOT test (but skipped due to b/489205940)
Local test: https://paste.googleplex.com/6403591735738368. The compilation was successful.
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.