Skip to content

feature: add chat sound mute toggle#411

Open
zeeshaun wants to merge 4 commits into
5stackgg:mainfrom
zeeshaun:fix/chat-sound-mute-toggle
Open

feature: add chat sound mute toggle#411
zeeshaun wants to merge 4 commits into
5stackgg:mainfrom
zeeshaun:fix/chat-sound-mute-toggle

Conversation

@zeeshaun

@zeeshaun zeeshaun commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

Summary

Adds a chat sound mute toggle to chat surfaces so players can silence incoming chat notifications while staying in chat.

Changes

  • Adds speaker/mute controls to the chat lobby header and right-side chat panel.
  • Shares useSound() state across callers so the toggle and notification playback use the same enabled state.
  • Persists the setting through the existing chat-sound-enabled localStorage key.
  • Prevents both notification beeps from playing when chat sound is muted.

Validation

  • Manually tested locally with two Steam accounts on the same match chat:
    • Verified the chat mute button appears in the match/right chat panel.
    • Verified muting sets localStorage.chat-sound-enabled to false and persists after refresh.
    • Verified incoming messages from the second account do not play a sound while muted.
    • Verified incoming messages play the notification sound again after unmuting.

Change was tested locally through the running Tilt dev stack.

@lukepolo

lukepolo commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

can you also add auto mute when they are in a match and in game?

@zeeshaun zeeshaun marked this pull request as ready for review June 1, 2026 00:28
@zeeshaun zeeshaun force-pushed the fix/chat-sound-mute-toggle branch from feafee5 to eea0289 Compare June 1, 2026 00:34
@zeeshaun zeeshaun changed the title [codex] Add chat sound mute toggle Add chat sound mute toggle Jun 1, 2026
@zeeshaun zeeshaun marked this pull request as draft June 1, 2026 00:38
@lukepolo lukepolo changed the title Add chat sound mute toggle feature: add chat sound mute toggle Jun 1, 2026
@lukepolo

lukepolo commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

let me know when its ready , so far it looks good , not sure what testing you need todo etc

@zeeshaun

zeeshaun commented Jun 1, 2026

Copy link
Copy Markdown
Contributor Author

I tested in the browser using devtools and added a vitest unit test.

I did not have a server spin up locally and test though.

@zeeshaun zeeshaun marked this pull request as ready for review June 1, 2026 20:08
@lukepolo

lukepolo commented Jun 2, 2026

Copy link
Copy Markdown
Contributor
image this messed up the input positioning

@zeeshaun

zeeshaun commented Jun 2, 2026

Copy link
Copy Markdown
Contributor Author

Should be resolved:

Screenshot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants