fix(config): require custom provider endpoint - #249
Conversation
Prevent saving custom provider configurations without a base URL. Closes #201
|
Warning Review limit reached
Next review available in: 58 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 327119e66f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (updatedConfig.provider === CUSTOM_PROVIDER_KEY && !updatedConfig.baseUrl) { | ||
| throw new Error('Custom provider requires a configured baseUrl. Set baseUrl before selecting __custom__.'); |
There was a problem hiding this comment.
When COMMIT_ECHO_BASE_URL supplies the custom endpoint, config set provider __custom__ now fails because configSetCommand constructs this value from loadRawConfig(), so updatedConfig.baseUrl ignores the environment override. The same check also blocks every config set operation for an existing raw custom-provider config whose endpoint is environment-only, even though loadConfig() produces a valid runtime configuration. Accept the effective environment endpoint for validation without persisting it, since all config keys, including baseUrl, are supported through COMMIT_ECHO_* overrides.
AGENTS.md reference: AGENTS.md:L60-L60
Useful? React with 👍 / 👎.
|
1 participant
Summary
Prevents
config set provider __custom__from saving a configuration that has no custom endpoint.Changes
baseUrl.Testing
npm run buildnode --test tests/config-command.test.mjsRelated
Closes #201