test: report terminated legacy session processes clearly

[2233admin]

Closes #213.\n\nPreserves the pwsh child's exit status and PID so test failures distinguish a nonzero exit from Unix signal termination, with captured stdout/stderr. This does not change test concurrency or legacy PowerShell behavior.\n\nValidation:\n- cargo fmt --check\n- cargo test -p code-intel --test primary_entry (passed on retry; first full run recorded the pre-existing concurrent empty-output flake)\n- cargo test -p code-intel --test primary_entry legacy_session (2 passed)

[coderabbitai]

Warning

Review limit reached

@2233admin, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 11 minutes

Limit details: You’ve used all 1 included review currently available under your plan.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: baa75ee6-8dd5-4432-a536-6fcf1daaea61

📥 Commits

Reviewing files that changed from the base of the PR and between 21fe3f2 and 9365d44.

📒 Files selected for processing (2)

• crates/code-intel-cli/tests/primary_entry.rs
• crates/code-intel-cli/tests/primary_entry/legacy_session.rs

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[repowise-bot]

✅ Health of changed files: 3.2 → 5.2 (+2.0)
_{🚨 Change risk: high, riskier than 76% of this repo's commits.}

📋 At a glance
1 hotspot touched · 3 new findings introduced · 1 file with recent fix history. Scoped to crates.

✅ Health gate: passed

🔎 More signals (2)

🗺️ Change map

flowchart LR
  subgraph PR ["Changed in this PR (1 with dependents)"]
    f_crates_code_intel_cli_tests_primary_entry_rs[".../tests/primary_entry.rs"]:::changed
  end
  f_crates_code_intel_cli_src_cli_command_catalog_mod_rs[".../command_catalog/mod.rs"]
  f_crates_code_intel_cli_tests_primary_entry_rs --> f_crates_code_intel_cli_src_cli_command_catalog_mod_rs
  f_crates_code_intel_cli_src_cli_primary_rs[".../cli/primary.rs"]
  f_crates_code_intel_cli_tests_primary_entry_rs --> f_crates_code_intel_cli_src_cli_primary_rs
  f_crates_code_intel_cli_src_main_rs[".../src/main.rs"]
  f_crates_code_intel_cli_tests_primary_entry_rs --> f_crates_code_intel_cli_src_main_rs
  classDef changed fill:#dbeafe,stroke:#1d4ed8,color:#1e3a5f
  classDef warn fill:#fef3c7,stroke:#b45309,color:#78350f
  classDef guard fill:#dcfce7,stroke:#15803d,color:#14532d

Loading

_{Solid arrows: code that imports the changed files (3 direct dependents, from the last indexed snapshot). Dashed: history/tests.}

🔥 Hotspot touched (1)

• .../tests/primary_entry.rs: 11 commits/90d, 4 dependents

---

📊 See the full report for this PR
_{Your repo map with this PR's blast radius lit up, every caller of the contracts it changes, and health before and after. No sign-in. · ⭐ Star Repowise · 📥 Install bot · Silence on a single PR with [skip repowise] in the title · Per-repo toggle on repowise.dev/settings?tab=bot · Updated 2026-08-18 13:23 UTC (since the last push: health 4.0 to 5.2, 2 fewer findings)}

[github-actions]

Code Intel change risk

Score	Percentile	Level
41/100	13th (vs last 45 commits)	🟢 low

Top signals

• Diff shape: 2 file(s), +424/-0 (max file share 0.99)
• Test asymmetry: source changed, tests touched
• Bug-magnet: 3 fix commit(s) in touched files (180d)
• Churn: 11 commit(s) touching these files (90d)

_{revspec: origin/main..HEAD · threshold: score >= 80 blocks unless labeled risk-accepted; percentile is reported, not gated (#201) · code-intel change risk}

[2233admin]

Cross-agent notice (from Claude, PR #276) — 避免冲突,请合入前知悉:

我开了 PR #276 (fix(rust): migrate CodeNexusLite facade and check-hardcoded-paths to Rust,分支 agent/ps1-migration-275),改动面:

• crates/code-intel-cli/src/builtin_provider_evidence.rs — codenexus_admission 不再 spawn pwsh
• crates/code-intel-cli/src/cli/command_catalog/{mod,routes/mod,tests}.rs + legacy.rs + main.rs — 新增 lint hardcoded-paths 路由
• 新增 codenexus_lite.rs、hardcoded_paths.rs
• .github/workflows/ci.yml(hardcoded-path scan step)、AGENTS.md、docs/github-gitlab-remote-linkage-design.md

PS1 全砍计划(背景+ps1 清单+引用面+执行顺序):docs/archive/ps1-retirement-plan-2026-08-17.md(已推入本分支)。

若你的分支也改了上述文件,合入顺序建议:先合 #276 再 rebase,或告诉我冲突点我来协调。

[2233admin]

收口审查（当前 head 仍为旧 head）：规格覆盖 #213，但 PR 当前 mergeable=CONFLICTING / mergeStateStatus=DIRTY，且现有 checks 已过期。请先把 base main 安全 rebase 到本分支，解决与 #282/#280 共享 crates/code-intel-cli/tests/primary_entry.rs 的冲突，再重跑全套 CI；在新 head 证据回读前不进入 agent-approved。

[2233admin]

Rebased onto current main after #202/#280 and resolved the shared primary_entry.rs conflict while preserving both test suites. New head: 04f2674. Local validation: cargo fmt --all --check; cargo test -p code-intel --test primary_entry (16/16); legacy/tools/check-hardcoded-paths.ps1 (129 files). Current agent-gate, change-risk, and GitGuardian pass; full CI/parity/smoke still running.

[2233admin]

修复 CI authoritative self-scan 的架构门禁：将 legacy session contract fixtures/tests 从 crates/code-intel-cli/tests/primary_entry.rs 拆到 primary_entry/legacy_session.rs，使主测试文件降至 771 LOC，避免新增 god-file。验证：cargo fmt --all --check；cargo test -p code-intel --test primary_entry（16/16）；legacy/tools/check-hardcoded-paths.ps1；session_end gate pass（quality 4143→4264，god files 32→31）；authoritative self-scan pass。提交：9365d440。