Skip to content

feat(project): 支持为现有角色增加动作 - #375

Open
xyh202131 wants to merge 2 commits into
1024XEngineer:mainfrom
xyh202131:feat/project-add-action
Open

feat(project): 支持为现有角色增加动作#375
xyh202131 wants to merge 2 commits into
1024XEngineer:mainfrom
xyh202131:feat/project-add-action

Conversation

@xyh202131

Copy link
Copy Markdown
Contributor

Closes #374

改动

  • 启用角色详情中的“增加动作”,提供 Quick Start 和 Workflow Editor 两种入口
  • 为现有 Character / Outfit 创建独立 WorkflowRun,复用当前造型母版并跳过角色设定与角色图生成
  • Quick Start 从动作描述直接提交首帧生成,不再复用角色原始 Run
  • Workflow Editor 按节点中的 characterId 恢复原角色,避免用新 Run ID 猜测角色
  • 缺少角色母版时禁用入口,创建失败时保留选择弹窗并展示错误

验证

  • npm run test -- --run --testTimeout=20000:621 passed,4 skipped
  • npm run typecheck
  • npm run lint
  • npm run build
  • 本次修改文件定向 oxfmt --check
  • git diff --check

@vercel

vercel Bot commented Aug 18, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
windup Ready Ready Preview Aug 18, 2026 6:13am

@codecov

codecov Bot commented Aug 18, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 90.24390% with 4 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
frontend/src/pages/character-detail/index.tsx 86.36% 0 Missing and 3 partials ⚠️
...s/workflow-controller/existing-character-action.ts 88.88% 0 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

@fennoai fennoai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review conclusion

本次改动在三条关键链路上保持一致:角色详情仅在当前 Outfit 有母版时开放入口;Quick Start 与 Workflow Editor 都会创建独立 WorkflowRun,并预置已完成的角色设定/母版节点;编辑器再从节点中的 characterId 恢复原角色,同时校验项目归属。保存动作仍沿用现有发布与冲突回滚流程,未发现会导致错误角色绑定、复用原 Run 或破坏现有动作资产的可报告问题。

验证方面,git diff --check 通过。尝试运行四个定向测试和 typecheck,但当前工作区未安装可用的前端依赖(vitest 启动器不可执行且模块不存在),因此无法在本地复跑;GitHub 上 Frontend checkslint-and-test 在审查时仍在运行。

@huyanxius

Copy link
Copy Markdown
Collaborator

@xyh202131 projects 界面已更新,请适配最新版本

@johnnyzhang-eng johnnyzhang-eng left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

抽出 createExistingCharacterActionRun 之后,原先那段拉 100 条 run 再按 characterId 猜的查法也一并去掉了,改成新建独立 Run,这比按列表猜稳。母版取 outfit.previewUrl 而不是角色级参考图,方向和 #253 要做的一致。CI 全绿。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

项目角色详情支持为现有角色增加动作

3 participants