Skip to content

Add rockspec file for installing from the repo directly#59

Open
mtourne wants to merge 1 commit into
wahern:masterfrom
mtourne:master
Open

Add rockspec file for installing from the repo directly#59
mtourne wants to merge 1 commit into
wahern:masterfrom
mtourne:master

Conversation

@mtourne

@mtourne mtourne commented Aug 19, 2016

Copy link
Copy Markdown

I needed master rather than the version on luarocks to fix this issue :

#53

Seemed easier to make the existing rockspec file work with the repo rather than figure out the build system

@mtourne

mtourne commented Aug 20, 2016

Copy link
Copy Markdown
Author

ps. open to constructive criticism beyond a thumbs up / down (:

@daurnimator

Copy link
Copy Markdown
Collaborator

So far I've been maintaining the rockspec outside of the repo; I believe @wahern prefers to build+install via make.

I'd prefer we kept the status quo; we just need a release...

@mtourne

mtourne commented Sep 24, 2016

Copy link
Copy Markdown
Author

My guess was that adding a separate option for installing as an added convenience could only be a plus, and never a downside.

@daurnimator

Copy link
Copy Markdown
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants