Skip to content

Vouch Request - Nikhil Shukl #3761

@nikhil-shukl

Description

@nikhil-shukl

Why do you want to contribute?

Hi Trigger.dev maintainers, I would like to contribute a focused fix for issue #3726.

I prepared a branch that updates ExponentialBackoff.execute() so maxElapsed also accounts for callback execution time, including attemptTimeoutMs paths. My original PR was auto-closed because I am not vouched yet: #3760.

Branch: https://github.com/nikhil-shukl/trigger.dev/tree/codex/fix-backoff-max-elapsed
Closed PR: #3760
Issue: #3726

I also addressed the automated review finding about AttemptTimeout bypassing the elapsed check and added focused regression coverage.

Prior contributions or relevant experience

Relevant work for this request:

GitHub: https://github.com/nikhil-shukl

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions