Skip to content

Commit e69e13e

Browse files
committed
fix(webapp): queue page button order Period-Investigate-Watch-Override-Pause, secondary Investigate there
1 parent a8ed165 commit e69e13e

2 files changed

Lines changed: 19 additions & 14 deletions

File tree

  • apps/webapp/app

apps/webapp/app/components/dashboard-agent/InvestigateButton.tsx

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,11 @@ export function InvestigateButton({
2525
prompt: string;
2626
label?: string;
2727
size?: "small" | "medium";
28-
/** `primary` for the standalone accent button, `minimal` inside menus. */
29-
variant?: "primary" | "minimal";
28+
/**
29+
* `primary` for the standalone accent button, `minimal` inside menus,
30+
* `secondary` where it sits in a row of grey buttons (the queue page).
31+
*/
32+
variant?: "primary" | "secondary" | "minimal";
3033
fullWidth?: boolean;
3134
className?: string;
3235
tooltip?: string;

apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.queues_.$queueParam/route.tsx

Lines changed: 14 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -342,6 +342,20 @@ export default function Page() {
342342
maxPeriodDays={maxPeriodDays}
343343
shortcut={{ key: "d" }}
344344
/>
345+
{/* The agent pair, Investigate then Watch. Both self-hide without the
346+
agent, and both dress as secondary here — one grey row, no accent.
347+
Investigate: hand a backed-up queue over. Watch: the universal
348+
entry, pre-filled with this queue's recommendation — if runs start
349+
waiting past the SLA, or, when they already are (the same signal
350+
`degraded` comes from), when the queue drains. */}
351+
{degraded ? (
352+
<InvestigateButton
353+
prompt={queueBacklogPrompt(queue.name)}
354+
variant="secondary"
355+
tooltip="Ask why this queue is backed up"
356+
/>
357+
) : null}
358+
<WatchButton spec={queueWatchRecommendation(queue.name, { oldestWaitMs })} />
345359
<QueueOverrideConcurrencyButton
346360
queue={queue}
347361
environmentConcurrencyLimit={environmentConcurrencyLimit}
@@ -352,18 +366,6 @@ export default function Page() {
352366
variant="secondary/small"
353367
withQueueName
354368
/>
355-
{/* The agent pair, Investigate then Watch. Both self-hide without the
356-
agent. Investigate: hand a backed-up queue over. Watch: the
357-
universal entry, pre-filled with this queue's recommendation —
358-
if runs start waiting past the SLA, or, when they already are
359-
(the same signal `degraded` comes from), when the queue drains. */}
360-
{degraded ? (
361-
<InvestigateButton
362-
prompt={queueBacklogPrompt(queue.name)}
363-
tooltip="Ask why this queue is backed up"
364-
/>
365-
) : null}
366-
<WatchButton spec={queueWatchRecommendation(queue.name, { oldestWaitMs })} />
367369
</div>
368370
</MetricsLayout.Filters>
369371

0 commit comments

Comments
 (0)