fix(webapp): take the queue metric day budget exactly as the plan gives it

Rounding the plan's query period up to a whole day would have let these pages
read further back than every other metric query for a sub-day limit. The budget
is now used as-is, matching the bound executeQuery enforces, and the period
string derived from it steps down to hours or minutes so a fractional budget
still yields a window inside it.

Author: ericallam

apps/webapp/app/components/queues/queueMetricsPeriod.server.ts

@@ -7,7 +7,7 @@ import { QUEUE_METRICS_RETENTION_DAYS } from "./queueMetricsPeriod";
  * and go straight to ClickHouse stay in step with the ones that don't.
  *
  * Read through the limit cache: the queues page revalidates on an interval, so this runs far more
- * often than a one-off page load. Whole days keep the derived period string well formed.
+ * often than a one-off page load.
  */
 export async function queueMetricsMaxPeriodDays(organizationId: string): Promise<number> {
   const cached = await getCachedLimit(
@@ -16,5 +16,5 @@ export async function queueMetricsMaxPeriodDays(organizationId: string): Promise
     QUEUE_METRICS_RETENTION_DAYS
   );
   const planPeriodDays = cached.val ?? QUEUE_METRICS_RETENTION_DAYS;
-  return Math.max(1, Math.min(Math.floor(planPeriodDays), QUEUE_METRICS_RETENTION_DAYS));
+  return Math.min(planPeriodDays, QUEUE_METRICS_RETENTION_DAYS);
 }

apps/webapp/app/components/queues/queueMetricsPeriod.ts

@@ -25,7 +25,9 @@ const PERIOD_PATTERN = /^\d+[mhd]$/;
 /** Queue metrics are retained for 30 days, so a longer window can only ever render empty. */
 export const QUEUE_METRICS_RETENTION_DAYS = 30;
 
-const DAY_MS = 24 * 60 * 60 * 1000;
+const MINUTE_MS = 60 * 1000;
+const HOUR_MS = 60 * MINUTE_MS;
+const DAY_MS = 24 * HOUR_MS;
 const MAX_PERIOD_MS = QUEUE_METRICS_RETENTION_DAYS * DAY_MS;
 
 function isPeriod(value: string | undefined | null): value is string {
@@ -90,13 +92,23 @@ export function resolveQueueMetricsPeriod({
 }
 
 /**
- * Hold a period inside a day budget (the org's plan query period). A remembered period longer than
- * the plan allows becomes the plan's maximum, so the picker shows the window the data covers.
+ * Hold a period inside a day budget (the org's plan query period). A period longer than the plan
+ * allows becomes the plan's maximum, so the picker shows the window the data covers.
+ *
+ * The budget is whatever the plan says, not necessarily a whole number of days, so the replacement
+ * is expressed in the largest unit that divides it: rounding down keeps the period inside the
+ * budget rather than a hair over it.
  */
 export function clampQueueMetricsPeriod(period: string, maxPeriodDays: number): string {
+  const maxMs = maxPeriodDays * DAY_MS;
   const ms = parse(period);
-  if (typeof ms === "number" && ms > 0 && ms <= maxPeriodDays * DAY_MS) return period;
-  return `${maxPeriodDays}d`;
+  if (typeof ms === "number" && ms > 0 && ms <= maxMs) return period;
+
+  const days = Math.floor(maxMs / DAY_MS);
+  if (days >= 1) return `${days}d`;
+  const hours = Math.floor(maxMs / HOUR_MS);
+  if (hours >= 1) return `${hours}h`;
+  return `${Math.max(1, Math.floor(maxMs / MINUTE_MS))}m`;
 }
 
 /**