fix(webapp): address review feedback on favorites active state and confirm settling

Two fixes from review. Arriving on a favorited org settings or account
page via its favorite left that page's side menu with nothing
highlighted: the shared menu item suppressed its active state whenever
a favorite owned the view, but those menus never render the favorites
list that would carry the highlight instead. Yielding the active state
to a favorite is now opt-in, set only by the main project menu and its
dashboards list.

Also, if the customize sidebar save settled with no response body (for
example a session-expiry redirect), the Confirm button could spin
forever; that case now surfaces the save error instead.

Author: samejr

apps/webapp/app/components/navigation/DashboardList.tsx

@@ -184,6 +184,7 @@ function DashboardChildMenuItem({
       to={item.path}
       isCollapsed={isCollapsed}
       disableIconHover
+      yieldActiveToFavorite
       action={
         showDragHandle ? (
           <div className="sidebar-drag-handle flex h-full w-full cursor-grab items-center justify-center rounded text-text-dimmed opacity-0 group-hover/menuitem:opacity-100 hover:text-text-bright active:cursor-grabbing">

apps/webapp/app/components/navigation/SideMenu.tsx

@@ -424,7 +424,12 @@ export function SideMenu({
     }
     if (!customizeSubmitSeenRef.current) return; // submit hasn't been picked up yet
     const data = customizationFetcher.data;
-    if (!data) return;
+    if (!data) {
+      // Settled with no response body (e.g. a session-expiry redirect): fail rather than spin
+      setCustomizeConfirmPending(false);
+      setCustomizeError("Couldn't save your changes. Please try again.");
+      return;
+    }
     if (data.success) {
       // Wait out the post-save revalidation so the menu behind the dialog reflects the changes
       if (revalidator.state !== "idle") return;
@@ -1152,6 +1157,7 @@ export function SideMenu({
                 to={v3EnvironmentPath(organization, project, environment)}
                 data-action="tasks"
                 isCollapsed={isCollapsed}
+                yieldActiveToFavorite
               />
               <SideMenuItem
                 name="Runs"
@@ -1161,6 +1167,7 @@ export function SideMenu({
                 to={v3RunsPath(organization, project, environment)}
                 data-action="runs"
                 isCollapsed={isCollapsed}
+                yieldActiveToFavorite
               />
               <SideMenuItem
                 name="Sessions"
@@ -1171,6 +1178,7 @@ export function SideMenu({
                 data-action="sessions"
                 badge={<NewBadge />}
                 isCollapsed={isCollapsed}
+                yieldActiveToFavorite
               />
             </div>
 
@@ -1334,6 +1342,7 @@ function CustomizableSideMenuSection({
             badge={item.badge}
             isCollapsed={isCollapsed}
             action={item.action}
+            yieldActiveToFavorite
           />
           {item.after}
         </Fragment>

apps/webapp/app/components/navigation/SideMenuItem.tsx

@@ -85,6 +85,7 @@ export function SideMenuItem({
   disableIconHover = false,
   indented = false,
   isActive: isActiveOverride,
+  yieldActiveToFavorite = false,
   "data-action": dataAction,
 }: {
   icon?: RenderIcon;
@@ -105,13 +106,22 @@ export function SideMenuItem({
   indented?: boolean;
   /** Overrides the default pathname === to active check (e.g. favorites match on full URL). */
   isActive?: boolean;
+  /**
+   * In menus that render the Favorites section (the main project menu), an active favorite owns
+   * the highlight, so the plain item yields its active state to it. Menus without a favorites
+   * list (org settings, account) must not set this: they have no favorite item to carry the
+   * highlight instead.
+   */
+  yieldActiveToFavorite?: boolean;
   "data-action"?: string;
 }) {
   const pathName = usePathName();
-  // When one of the user's OWN favorites owns the current view (via its marker param), it takes
-  // the active state; markers from shared links don't count (see useActiveFavoriteId).
+  // Only the user's OWN favorites own a view (via the marker param); markers from shared links
+  // don't count (see useActiveFavoriteId).
   const activeFavoriteId = useActiveFavoriteId();
-  const isActive = isActiveOverride ?? (pathName === to && activeFavoriteId === undefined);
+  const isActive =
+    isActiveOverride ??
+    (pathName === to && (!yieldActiveToFavorite || activeFavoriteId === undefined));
 
   const isIndented = indented && !isCollapsed;