Skip to content

Commit 6b31d5c

Browse files
committed
chore(webapp): remove tests for deleted v3 services and tidy review nits
Delete the unit tests for the removed createCheckpoint and cancelDevSessionRuns services, apply formatting, and reword the changeset plus agent-guidance docs to note that a V1 branch may finalize (not only reject) gracefully.
1 parent c0469a5 commit 6b31d5c

7 files changed

Lines changed: 4 additions & 323 deletions

File tree

.changeset/retire-v3-zod-namespace.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,4 +2,4 @@
22
"@trigger.dev/core": patch
33
---
44

5-
Removed unused v3 (engine V1) exports that are no longer referenced now that the v3 engine is retired: the `@trigger.dev/core/v3/zodNamespace` subpath and the legacy v3 socket message catalogs (coordinator, provider, shared-queue, prod-worker, and background-worker websocket).
5+
Removed the unused `@trigger.dev/core/v3/zodNamespace` export and the legacy v3 socket message schemas. These were only used by the now-retired v3 engine and have no v4 consumers.

.claude/rules/legacy-v3-code.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ paths:
77

88
The v3 engine (RunEngineVersion `V1`: MarQS queue + Graphile worker) is end-of-life and its execution code has been removed from the webapp. The `app/v3/` directory name is historical: everything under it now serves the current V2 engine (`@internal/run-engine` + `@trigger.dev/redis-worker`).
99

10-
There is no `V1` execution path anymore. If you find a `RunEngineVersion` branch, the `V1` arm should only ever produce a graceful rejection, never run work. Do not reintroduce MarQS, the graphile worker, or the v3 socket.io namespaces.
10+
There is no `V1` execution path anymore. If you find a `RunEngineVersion` branch, the `V1` arm should only reject or finalize gracefully (for example, mark a historical run cancelled in the DB), never run V1 work. Do not reintroduce MarQS, the graphile worker, or the v3 socket.io namespaces.
1111

1212
## The deprecation boundary (keep this)
1313

AGENTS.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -142,7 +142,7 @@ User API call -> Webapp routes -> Services -> RunEngine -> Redis Queue -> Superv
142142

143143
### v3 (engine V1) removed
144144

145-
v3 (engine V1: MarQS + Graphile worker) is end-of-life and its execution code has been removed. The `apps/webapp/app/v3/` directory name is historical - everything there now serves V2 (Run Engine 2.0, `@internal/run-engine` + redis-worker). There is no V1 execution path: a `RunEngineVersion` `V1` branch only rejects gracefully so v3 clients get a clean 4xx, never a 5xx. Do not reintroduce V1. See `apps/webapp/CLAUDE.md` and `.claude/rules/legacy-v3-code.md`.
145+
v3 (engine V1: MarQS + Graphile worker) is end-of-life and its execution code has been removed. The `apps/webapp/app/v3/` directory name is historical - everything there now serves V2 (Run Engine 2.0, `@internal/run-engine` + redis-worker). There is no V1 execution path: a `RunEngineVersion` `V1` branch only rejects or finalizes gracefully so v3 clients get a clean 4xx, never a 5xx. Do not reintroduce V1. See `apps/webapp/CLAUDE.md` and `.claude/rules/legacy-v3-code.md`.
146146

147147
### Documentation
148148

apps/webapp/app/components/admin/debugRun.tsx

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -74,11 +74,7 @@ function DebugRunData(props: UseDataFunctionReturn<typeof loader>) {
7474
return <DebugRunDataEngineV2 {...props} />;
7575
}
7676

77-
function DebugRunDataEngineV1({
78-
run,
79-
}: {
80-
run: UseDataFunctionReturn<typeof loader>["run"];
81-
}) {
77+
function DebugRunDataEngineV1({ run }: { run: UseDataFunctionReturn<typeof loader>["run"] }) {
8278
return (
8379
<Property.Table>
8480
<Property.Item>

apps/webapp/app/v3/services/changeCurrentDeployment.server.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -173,7 +173,6 @@ export class ChangeCurrentDeploymentService extends BaseService {
173173
error: scheduleSyncError,
174174
});
175175
}
176-
177176
}
178177

179178
async #syncSchedulesForDeployment(deployment: WorkerDeployment) {

apps/webapp/test/cancelDevSessionRunsStoreRouting.test.ts

Lines changed: 0 additions & 249 deletions
This file was deleted.

apps/webapp/test/createCheckpoint.batchReplicaLag.test.ts

Lines changed: 0 additions & 65 deletions
This file was deleted.

0 commit comments

Comments
 (0)