fix(webapp): stop saying error twice when naming a watched error

Author: kathiekiwi

apps/webapp/app/components/dashboard-agent/watch-card.test.ts

@@ -270,6 +270,19 @@ describe("the card's copy", () => {
     expect(watchSubjectLabel(healthWatchRecommendation("warn"))).toBe("health");
   });
 
+  it("says the kind once, though the fingerprint carries it too", () => {
+    // Fingerprints are stored prefixed (`error_c4b4a797397a9c43`), so shortening the
+    // raw value would read "error error_c4".
+    expect(
+      watchSubjectLabel({
+        kind: "error_recurrence",
+        fingerprint: "error_c4b4a797397a9c43",
+        checkEveryMinutes: 5,
+        maxHours: 0.5,
+      })
+    ).toBe("error c4b4a797");
+  });
+
   it("states the condition and the duration as §2.2 writes them", () => {
     const spec = queueWatchRecommendation("email-sends", { oldestWaitMs: OLDEST_WAIT_WARNING_MS });
     expect(watchConditionLabel(spec)).toBe("Until the queue drains");

apps/webapp/app/components/dashboard-agent/watch-chips.ts

@@ -12,7 +12,11 @@ import type { WatchStatus } from "@internal/dashboard-agent-contracts";
 // user-facing copy. Re-exported here for chip callers.
 export { immediateWatchMessage } from "~/presenters/v3/dashboardAgent";
 
-import { formatWatchCadence, watchIdentityValue } from "~/presenters/v3/dashboardAgent";
+import {
+  formatWatchCadence,
+  shortFingerprint,
+  watchIdentityValue,
+} from "~/presenters/v3/dashboardAgent";
 
 export const WATCH_STATUS_LABEL: Record<WatchStatus, string> = {
   active: "watching",
@@ -22,8 +26,6 @@ export const WATCH_STATUS_LABEL: Record<WatchStatus, string> = {
 };
 
 /** Fingerprints are hashes — a chip shows just enough of one to tell them apart. */
-const FINGERPRINT_CHARS = 8;
-
 /**
  * The chip label for a watch. `identity` is `{kind}:{value}`, so the value is the
  * thing being watched; a health watch has no per-instance value, so its kind is
@@ -48,7 +50,7 @@ export function watchChipLabel(watch: { kind: string; identity: string; note: st
     case "queue_oldest_age":
       return watchIdentityValue(watch.kind, watch.identity) || fallbackLabel(watch);
     case "error_recurrence":
-      return value ? value.slice(0, FINGERPRINT_CHARS) : fallbackLabel(watch);
+      return value ? shortFingerprint(value) : fallbackLabel(watch);
     case "health_recovery":
       return "health";
     default:

apps/webapp/app/presenters/v3/dashboardAgent/watch-wording.ts

@@ -17,6 +17,7 @@ export {
   WATCH_IN_CHAT_DELIVERY_LINE,
   WATCH_PRESENTATION_FALLBACK,
   WATCH_UPDATE_LABEL,
+  shortFingerprint,
   watchConditionLabel,
   watchConditionWording,
   watchConfirmationBlockBody,

internal-packages/dashboard-agent-contracts/src/watch-wording.ts

@@ -35,6 +35,15 @@ export const WATCH_UPDATE_LABEL = "Watch update";
 /** Fingerprints are hashes, so show just enough to tell them apart. */
 const FINGERPRINT_CHARS = 8;
 
+/**
+ * A fingerprint carries its own `error_` prefix, and every surface names the kind
+ * itself — so the prefix is dropped before shortening, or the line reads
+ * "error error_c4".
+ */
+export function shortFingerprint(fingerprint: string): string {
+  return fingerprint.replace(/^error_/, "").slice(0, FINGERPRINT_CHARS);
+}
+
 /* ------------------------------------------------------------------ *
  * Identity formatting
  * ------------------------------------------------------------------ */
@@ -80,7 +89,7 @@ function bareQueueName(identity: string, kind: string): string {
 /** How an error group is named in a sentence. */
 function errorName(identity: string, kind: string): string {
   const value = watchIdentityValue(kind, identity);
-  return value ? `Error ${value.slice(0, FINGERPRINT_CHARS)}` : "The error";
+  return value ? `Error ${shortFingerprint(value)}` : "The error";
 }
 
 /* ------------------------------------------------------------------ *
@@ -486,7 +495,7 @@ export function watchSubjectLabel(spec: WatchSpec): string {
     case "queue_oldest_age":
       return spec.queue;
     case "error_recurrence":
-      return `error ${spec.fingerprint.slice(0, FINGERPRINT_CHARS)}`;
+      return `error ${shortFingerprint(spec.fingerprint)}`;
     case "health_recovery":
       return "health";
   }