fix: address CodeRabbit review on #4418

- waiting-run diagnosis: 'unknown' with concurrency evidence in hand no longer
  claims the evidence is missing; an elapsed delay says 'not yet enqueued'
  instead of hiding behind time-from-creation
- queue metrics route: drop the double decode that 500ed on names with a
  literal percent sign
- evidence schema: kind must match the URI's own kind
- seed-queue-metrics: default-binding imports like the other seeders

Author: kathiekiwi

apps/webapp/app/presenters/v3/waitingRun/waitingRunDiagnosis.ts

@@ -238,6 +238,12 @@ function describeRun(run: WaitingRunRow, now: Date): WaitingRunDiagnosis["run"]
     // A delayed run isn't in the queue yet — this is a schedule, NOT queue latency.
     waitingLabel = `scheduled to start at ${run.delayUntil.toISOString()}`;
     waitingBasis = "delay_until";
+  } else if (run.delayUntil && run.queuedAt === null) {
+    // The delay elapsed but the run hasn't been enqueued yet — say that, not "time from
+    // creation", which would hide that the schedule already passed.
+    const ms = Math.max(0, now.getTime() - run.delayUntil.getTime());
+    waitingLabel = `delay elapsed ${formatMs(ms)} ago, not yet enqueued`;
+    waitingBasis = "delay_until";
   } else {
     // No queuedAt to measure from. Report creation age and SAY that's what it is.
     const ms = Math.max(0, (run.startedAt ?? now).getTime() - run.createdAt.getTime());
@@ -393,9 +399,14 @@ function deriveCause(
   if (!backlogged || (observedRate !== null && observedRate > 0)) {
     return { cause: "draining_normally", evidence };
   }
-  // Backlogged with nothing moving, but no capacity evidence to say whether that's a limit or a
-  // stall. flow.ts's lesson: don't name a concurrency cause without the evidence for it.
-  return { cause: "unknown", evidence: { ...evidence, missing: "env_concurrency" } };
+  // Backlogged with nothing conclusive. Only claim evidence is MISSING when it actually is —
+  // with concurrency evidence in hand this is "inconclusive", not "blind" (flow.ts's lesson:
+  // don't name a concurrency cause without the evidence for it, and don't mislabel evidence
+  // that's present).
+  return {
+    cause: "unknown",
+    evidence: { ...evidence, missing: hasConcurrencyEvidence ? null : "env_concurrency" },
+  };
 }
 
 // ---------------------------------------------------------------------------

apps/webapp/app/routes/api.v1.queues.$queueParam.metrics.ts

@@ -66,7 +66,9 @@ export const loader = createLoaderApiRoute(
     },
   },
   async ({ params, searchParams, authentication }) => {
-    const name = decodeURIComponent(params.queueParam).replace(/%2F/g, "/");
+    // Remix already URL-decoded the param and the schema's transform unescaped %2F —
+    // decoding again would throw a 500 on queue names containing a literal "%".
+    const name = params.queueParam;
     const queue = searchParams.type === "task" && !name.startsWith("task/") ? `task/${name}` : name;
 
     const windowMs = periodMs(searchParams.period);

apps/webapp/seed-queue-metrics.mts

@@ -1,9 +1,16 @@
-import { prisma } from "./app/db.server";
-import { createOrganization } from "./app/models/organization.server";
-import { createProject } from "./app/models/project.server";
 import { ClickHouse } from "@internal/clickhouse";
 import type { QueueMetricsRawV1Input } from "@internal/clickhouse";
-import { generateFriendlyId } from "./app/v3/friendlyIdentifiers";
+// App modules compile to CommonJS under tsx (webapp has no "type": "module"), so
+// import them as default bindings and destructure — same pattern as seed-agent-examples.
+import dbServer from "./app/db.server";
+import organizationServer from "./app/models/organization.server";
+import projectServer from "./app/models/project.server";
+import friendlyIdentifiers from "./app/v3/friendlyIdentifiers";
+
+const { prisma } = dbServer;
+const { createOrganization } = organizationServer;
+const { createProject } = projectServer;
+const { generateFriendlyId } = friendlyIdentifiers;
 
 // Queue metrics simulator: writes realistic raw rows into a synthetic tenant's
 // queue_metrics_raw_v1 and lets the MV build queue_metrics_v1 (the same path the real

apps/webapp/test/waitingRunDiagnosis.test.ts

@@ -224,7 +224,10 @@ describe("computeWaitingRunDiagnosis", () => {
         run({ status: "PENDING", queuedAt: null, delayUntil: new Date(NOW.getTime() - 60_000) }),
         signals()
       );
-      expect(result?.run.waitingBasis).toBe("created_at");
+      // The delay already passed but the run wasn't enqueued — the label says the
+      // delay elapsed rather than hiding it behind "time from creation".
+      expect(result?.run.waitingBasis).toBe("delay_until");
+      expect(result?.run.waitingLabel).toContain("not yet enqueued");
     });
   });
 

internal-packages/dashboard-agent-contracts/src/evidence.ts

@@ -7,18 +7,31 @@
  * validated, and it rots. If it can't be expressed as a URI, it isn't evidence.
  */
 import { z } from "zod";
-import { triggerUriKindSchema, triggerUriSchema } from "./trigger-uri.js";
+import { safeParseTriggerUri, triggerUriKindSchema, triggerUriSchema } from "./trigger-uri.js";
 
-export const evidenceSchema = z.object({
-  /** What kind of resource this cites. Mirrors the URI's resource kinds. */
-  kind: triggerUriKindSchema,
-  /** The resource itself. */
-  uri: triggerUriSchema,
-  /** Short human label, e.g. "run_abc123 failed span" or "processOrder.ts:42". */
-  label: z.string(),
-  /** Optional verbatim snippet (error message, log line, source lines). */
-  excerpt: z.string().optional(),
-});
+export const evidenceSchema = z
+  .object({
+    /** What kind of resource this cites. Mirrors the URI's resource kinds. */
+    kind: triggerUriKindSchema,
+    /** The resource itself. */
+    uri: triggerUriSchema,
+    /** Short human label, e.g. "run_abc123 failed span" or "processOrder.ts:42". */
+    label: z.string(),
+    /** Optional verbatim snippet (error message, log line, source lines). */
+    excerpt: z.string().optional(),
+  })
+  // A citation must not claim one resource type while pointing at another — the
+  // renderer picks its icon and label from `kind`, so a mismatch is a lie.
+  .superRefine((evidence, ctx) => {
+    const parsed = safeParseTriggerUri(evidence.uri);
+    if (parsed.success && parsed.data.kind !== evidence.kind) {
+      ctx.addIssue({
+        code: z.ZodIssueCode.custom,
+        path: ["kind"],
+        message: `kind "${evidence.kind}" does not match the URI's kind "${parsed.data.kind}"`,
+      });
+    }
+  });
 
 export type Evidence = z.infer<typeof evidenceSchema>;
 export type EvidenceKind = Evidence["kind"];