From 902e4117ae90bb8736953a02fd43aacc2abff643 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?M=C3=A1rton=20Boros?= Date: Tue, 28 Jul 2026 18:38:50 +0300 Subject: [PATCH] fix(ansible): drop no-op zpool loop item from zswap task zsmalloc has been zswap's default allocator since kernel 6.3 (Sept 2023), and Ubuntu noble has always shipped >= 6.8, so explicitly writing zpool=zsmalloc was a no-op on every kernel this fleet has run. Kernels >= 6.18 dropped the param entirely. Drop the item instead of guarding it, since setting it never did anything. No guard needed for the remaining params either: the original failure log shows compressor, max_pool_percent, and enabled all wrote successfully on the newest kernel observed (7.0.0-1009-aws) -- zpool was the only one that failed. Co-Authored-By: Claude Sonnet 5 --- ansible/tasks/setup-tuned.yml | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/ansible/tasks/setup-tuned.yml b/ansible/tasks/setup-tuned.yml index b63cb4363..59f193b6c 100644 --- a/ansible/tasks/setup-tuned.yml +++ b/ansible/tasks/setup-tuned.yml @@ -215,17 +215,13 @@ - name: 'tuned - Configure and enable zswap' # noqa: name[casing] ansible.builtin.shell: - # Kernels >= 6.18 dropped some zswap params (e.g. zpool, since zsmalloc - # is the only remaining backend); skip params the kernel doesn't expose. - cmd: "[ ! -w /sys/module/zswap/parameters/{{ zswap_item['param'] }} ] || echo {{ zswap_item['value'] }} > /sys/module/zswap/parameters/{{ zswap_item['param'] }}" + cmd: "echo {{ zswap_item['value'] }} > /sys/module/zswap/parameters/{{ zswap_item['param'] }}" changed_when: true loop: - param: 'compressor' value: 'zstd' - param: 'max_pool_percent' value: '10' - - param: 'zpool' - value: 'zsmalloc' - param: 'enabled' value: 'Y' loop_control: