Remove deprecated empty provider "time" block

[madejusz]

The provider "time" {} block in src/providers.tf (line 69) is a deprecated proxy provider configuration.

The time provider is already properly declared in required_providers in terraform.tf, which is sufficient. The empty block triggers a deprecation warning during terraform init.

Fix available here: madejusz@c3c3b81

btw. I'm currently working on a sovereign cloud deployment using this landing zone and will likely encounter more issues like this one. Would it be possible to grant contributor access so I can submit PRs directly instead of going through issues?

[mahauber]

Hi @madejusz, thanks for opening the issue.

The Redundant empty provider block warning only applies to child modules: it flags proxy provider configurations, i.e. an empty provider "x" {} in a module that expects a config from its caller via providers = {}. src/ is the root module, so it's exempt. Verified with OpenTofu 1.12.5: the block warns in a child module, and gives a clean Success! The configuration is valid. in the root. src/providers.tf:69 emits nothing at init, validate, or plan.

It is redundant though, since the time provider takes no configuration arguments, the pin in terraform.tf is what matters, and the default config is created implicitly either way. So removing it is safe cleanup. Happy to merge madejusz/stackit-landing-zone@c3c3b81 as a PR, just reworded so it doesn't claim a deprecation warning, e.g. chore: drop redundant empty time provider block.

On access: fork-and-PR is the standard path here and needs no write access. You can open PRs from your fork and we'll review them.