Fix 88, down with catchup#235
Open
rangzen wants to merge 2 commits into
Open
Conversation
Author
|
@rubenv Hello, any news on that PR? Thanks |
Author
|
@rubenv Do I have to update the PR or this PR is refused anyway? |
Author
|
Hello @rubenv do I update the PR or it will not be merged anyway? Thank you. |
|
It would be great to have the conflicts resolved. I created a new issue (#252) to explain the problem this PR is solving. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the case where a down operation is called, but some catch up operations are called also.
Actually, the records are wrong because the up operations are not updated with the applied date, they are ran by the down part which delete the date instead of inserting one.