Skip to content

Commit 7de7b77

Browse files
j-piaseckimeta-codesync[bot]
authored andcommitted
Cover the resize observer modules with Stable API guards (#58040)
Summary: Pull Request resolved: #58040 Classifies `react/renderer/observers/resize:resize` and `react/nativemodule/resizeobserver:resizeobserver` as private targets under the three-tier C++ stable API visibility model. Consumers that opt into `RN_STRICT_API` now get an error if they include their headers directly; without that flag the guards are inert, so no existing build changes behaviour. Changelog: [Internal] Reviewed By: christophpurrer Differential Revision: D116912836 fbshipit-source-id: f40f07dc6efbe874868d90e70f58f7b0e37f8d2b
1 parent e47416c commit 7de7b77

6 files changed

Lines changed: 10 additions & 0 deletions

File tree

packages/react-native/ReactCommon/react/nativemodule/resizeobserver/CMakeLists.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ target_include_directories(react_nativemodule_resizeobserver PUBLIC ${REACT_COMM
1616
target_link_libraries(react_nativemodule_resizeobserver
1717
react_codegen_rncore
1818
react_cxxreact
19+
react_cxxstableapi
1920
react_renderer_bridging
2021
react_renderer_core
2122
react_renderer_graphics

packages/react-native/ReactCommon/react/nativemodule/resizeobserver/NativeResizeObserver.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@
77

88
#pragma once
99

10+
#include <react/cxxstableapi/PrivateGuard.h>
11+
1012
#if __has_include("FBReactNativeSpecJSI.h") // CocoaPod headers on Apple
1113
#include "FBReactNativeSpecJSI.h"
1214
#else

packages/react-native/ReactCommon/react/nativemodule/resizeobserver/React-resizeobservernativemodule.podspec

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -61,8 +61,10 @@ Pod::Spec.new do |s|
6161
s.dependency "React-Fabric/bridging"
6262
s.dependency "React-Fabric/observers/resize"
6363
s.dependency "React-runtimescheduler"
64+
s.dependency "React-cxxstableapi"
6465
add_dependency(s, "React-RCTFBReactNativeSpec")
6566
add_dependency(s, "React-runtimeexecutor", :additional_framework_paths => ["platform/ios"])
6667
add_dependency(s, "React-graphics", :additional_framework_paths => ["react/renderer/graphics/platform/ios"])
6768

69+
mark_as_react_native_build(s)
6870
end

packages/react-native/ReactCommon/react/renderer/observers/resize/CMakeLists.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ target_include_directories(react_renderer_observers_resize PUBLIC ${REACT_COMMON
1616
target_link_libraries(react_renderer_observers_resize
1717
react_cxxreact
1818
react_bridging
19+
react_cxxstableapi
1920
react_renderer_core
2021
react_renderer_graphics
2122
react_renderer_mounting

packages/react-native/ReactCommon/react/renderer/observers/resize/ResizeObserver.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@
77

88
#pragma once
99

10+
#include <react/cxxstableapi/PrivateGuard.h>
11+
1012
#include <react/renderer/components/root/RootShadowNode.h>
1113
#include <react/renderer/core/ShadowNodeFamily.h>
1214
#include <react/renderer/graphics/Rect.h>

packages/react-native/ReactCommon/react/renderer/observers/resize/ResizeObserverManager.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@
77

88
#pragma once
99

10+
#include <react/cxxstableapi/PrivateGuard.h>
11+
1012
#include <jsi/jsi.h>
1113
#include <react/renderer/core/ShadowNodeFamily.h>
1214
#include <react/renderer/mounting/ShadowTree.h>

0 commit comments

Comments
 (0)