Skip to content

Remove the deprecated name and namespace fields from PermissionRequestBody #1902

Description

@rohilsurana

Background

Since #1885, CreatePermission and UpdatePermission read only PermissionRequestBody.key. The handlers ignore the request name and namespace fields entirely (internal/api/v1beta1connect/permission.go), and both fields are already marked Deprecated in the generated proto (proto/v1beta1/admin.pb.go).

So the two request fields are now dead inputs. Setting them has no effect, and a request that sends only name/namespace without a key is rejected.

What

Remove name and namespace from the PermissionRequestBody message in the proto (raystack/proton), then regenerate here.

Note: the Permission response message still returns name and namespace, and those are not deprecated. Keep them. This issue is only about the request body.

Why deprecate-first

The proto lives in raystack/proton and feeds generated SDKs, so removing request fields is a breaking change for any client still sending them. They are already inert server-side and marked deprecated, so the safe path is:

  1. Keep them marked deprecated for a release window (done as of refactor(api): require permission key in create and update requests #1885).
  2. Remove them from the proto and regenerate in a later release, called out in the changelog.

References

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions