You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Since #1885, CreatePermission and UpdatePermission read only PermissionRequestBody.key. The handlers ignore the request name and namespace fields entirely (internal/api/v1beta1connect/permission.go), and both fields are already marked Deprecated in the generated proto (proto/v1beta1/admin.pb.go).
So the two request fields are now dead inputs. Setting them has no effect, and a request that sends only name/namespace without a key is rejected.
What
Remove name and namespace from the PermissionRequestBody message in the proto (raystack/proton), then regenerate here.
Note: the Permissionresponse message still returns name and namespace, and those are not deprecated. Keep them. This issue is only about the request body.
Why deprecate-first
The proto lives in raystack/proton and feeds generated SDKs, so removing request fields is a breaking change for any client still sending them. They are already inert server-side and marked deprecated, so the safe path is:
Background
Since #1885,
CreatePermissionandUpdatePermissionread onlyPermissionRequestBody.key. The handlers ignore the requestnameandnamespacefields entirely (internal/api/v1beta1connect/permission.go), and both fields are already markedDeprecatedin the generated proto (proto/v1beta1/admin.pb.go).So the two request fields are now dead inputs. Setting them has no effect, and a request that sends only
name/namespacewithout akeyis rejected.What
Remove
nameandnamespacefrom thePermissionRequestBodymessage in the proto (raystack/proton), then regenerate here.Note: the
Permissionresponse message still returnsnameandnamespace, and those are not deprecated. Keep them. This issue is only about the request body.Why deprecate-first
The proto lives in raystack/proton and feeds generated SDKs, so removing request fields is a breaking change for any client still sending them. They are already inert server-side and marked deprecated, so the safe path is:
References