Skip to content
This repository was archived by the owner on Aug 1, 2023. It is now read-only.

[rfr] Extract additional info from GET#564

Open
kaccardi wants to merge 4 commits into
rackspace:masterfrom
kaccardi:expand-get-results
Open

[rfr] Extract additional info from GET#564
kaccardi wants to merge 4 commits into
rackspace:masterfrom
kaccardi:expand-get-results

Conversation

@kaccardi

@kaccardi kaccardi commented May 2, 2016

Copy link
Copy Markdown

Add some additional APIs to extract project, roles, and user information from a token retrieved with a GET request. Move ExtractServiceCatalog to commonResult since it can be obtained either with a POST or a GET.

kaccardi added 4 commits May 2, 2016 08:03
Add the ability to extract project information out of a scoped
v3 token.
Return a list of the roles associated with a scoped token.
The service catalog object can be retrieved from a GET request
when doing token validation as well as the POST request.
Get user information out of token information from a GET response
@coveralls

coveralls commented May 2, 2016

Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.2%) to 79.973% when pulling 36271d2 on kaccardi:expand-get-results into c54bbac on rackspace:master.

@jrperritt

Copy link
Copy Markdown
Contributor

When this is ready for review, throw a [rfr] tag in front of the title and I'll have a look.

@kaccardi kaccardi changed the title Extract additional info from GET [rfr] Extract additional info from GET May 16, 2016
@kaccardi

Copy link
Copy Markdown
Author

ok, I modified the title, thanks.


// Roles contains a list of role names extracted from a token.
type Roles struct {
Entries []RoleEntry

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a tag here?

@jrperritt

Copy link
Copy Markdown
Contributor

These look good. Can you add unit tests for them?

@kaccardi

Copy link
Copy Markdown
Author

yes, I will work on that.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants