Skip env_get_entry snapshot on non-buffered path (closes #228)

Author: python-processing-unit

src/builtins.c

@@ -9498,11 +9498,11 @@ static Value builtin_valuein(Interpreter *interp, Value *args, int argc, Expr **
 }
 
 static int validate_read_metadata(Map *tpl, int *typing, int *recurse, int *shape, int explicit_typing,
-                               int explicit_recurse, int explicit_shape);
+                                  int explicit_recurse, int explicit_shape);
 
 // Helper: recursive validate implementation
 static int validate_map_internal(Map *m, Map *tpl, int typing, int recurse, int shape, int explicit_typing,
-                              int explicit_recurse, int explicit_shape) {
+                                 int explicit_recurse, int explicit_shape) {
     if (!tpl) {
         return 1;
     }
@@ -9558,8 +9558,8 @@ static int validate_map_internal(Map *m, Map *tpl, int typing, int recurse, int
         if (recurse && mval.type == VAL_MAP && tval.type == VAL_MAP) {
             Map *mm = mval.as.map;
             Map *tt = tval.as.map;
-            int ok =
-                validate_map_internal(mm, tt, typing, recurse, shape, explicit_typing, explicit_recurse, explicit_shape);
+            int ok = validate_map_internal(mm, tt, typing, recurse, shape, explicit_typing, explicit_recurse,
+                                           explicit_shape);
             value_free(mval);
             if (!ok) {
                 return 0;
@@ -9572,7 +9572,7 @@ static int validate_map_internal(Map *m, Map *tpl, int typing, int recurse, int
 }
 
 static int validate_read_metadata(Map *tpl, int *typing, int *recurse, int *shape, int explicit_typing,
-                               int explicit_recurse, int explicit_shape) {
+                                  int explicit_recurse, int explicit_shape) {
     Value validate_key = value_str("validate");
     int found = 0;
     Value validate_value = value_map_get((Value){.type = VAL_MAP, .as.map = tpl}, validate_key, &found);
@@ -9621,7 +9621,8 @@ static int validate_read_metadata(Map *tpl, int *typing, int *recurse, int *shap
 }
 
 // VALIDATE(map, schema, typing=0, recurse=0, shape=0):int
-static Value builtin_validate(Interpreter *interp, Value *args, int argc, Expr **arg_nodes, Env *env, int line, int col) {
+static Value builtin_validate(Interpreter *interp, Value *args, int argc, Expr **arg_nodes, Env *env, int line,
+                              int col) {
     (void)arg_nodes;
     (void)env;
     (void)argc;

src/env.c

@@ -796,8 +796,8 @@ int env_permafreeze(Env *env, const char *name) {
 /* ================================================================== */
 
 EnvEntry *env_get_entry(Env *env, const char *name) {
-    EnvEntry *snap = env_entry_snap_alloc();
     if (ns_buffer_active() && !ns_buffer_is_prepare_thread()) {
+        EnvEntry *snap = env_entry_snap_alloc();
         ns_buffer_read_lock(name);
         EnvEntry *entry = env_get_entry_raw(env, name);
         env_entry_snap_from_raw(snap, entry);
@@ -809,14 +809,7 @@ EnvEntry *env_get_entry(Env *env, const char *name) {
         return snap;
     }
 
-    EnvEntry *entry = env_get_entry_raw(env, name);
-    env_entry_snap_from_raw(snap, entry);
-    if (!entry) {
-        // Clear to a canonical empty state and return NULL for not-found.
-        env_entry_snap_clear(snap);
-        return NULL;
-    }
-    return snap;
+    return env_get_entry_raw(env, name);
 }
 
 bool env_get(Env *env, const char *name, Value *out_value, DeclType *out_type, int *out_base, bool *out_initialized) {