From 5aa0f0fb4a2219c75a331a1e895ee36e1a42a092 Mon Sep 17 00:00:00 2001 From: Daniel Leech Date: Thu, 6 Aug 2026 08:35:05 +0100 Subject: [PATCH 1/2] Bump min php version to 8.2 --- .github/workflows/ci.yml | 5 ++++- composer.json | 2 +- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 457d8a11..42143564 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -19,7 +19,10 @@ jobs: strategy: matrix: php-version: - - '8.1' + - '8.2' + - '8.3' + - '8.4' + - '8.5' steps: - diff --git a/composer.json b/composer.json index e62be925..14011ebb 100644 --- a/composer.json +++ b/composer.json @@ -9,7 +9,7 @@ } ], "require": { - "php": "^8.1", + "php": "^8.2", "symfony/filesystem": "^4.2 || ^5.0 || ^6.0", "psr/log": "^1.0 || ^2.0 || ^3.0" }, From 74d776474efcad6a140199013fee8131a6f1457e Mon Sep 17 00:00:00 2001 From: Daniel Leech Date: Thu, 6 Aug 2026 08:42:10 +0100 Subject: [PATCH 2/2] Fix tests - Symfony made `Path::isAbsolute` platform specific - which for Phactor at least makes sense, but it means we can't test the windows behavior without adding a CI runner for Windows... --- .github/workflows/ci.yml | 10 +++++----- composer.json | 2 +- tests/Unit/Domain/FilePathTest.php | 15 --------------- 3 files changed, 6 insertions(+), 21 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 42143564..b49be93f 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -20,9 +20,6 @@ jobs: matrix: php-version: - '8.2' - - '8.3' - - '8.4' - - '8.5' steps: - @@ -55,7 +52,7 @@ jobs: strategy: matrix: php-version: - - '8.1' + - '8.2' steps: - @@ -88,7 +85,10 @@ jobs: strategy: matrix: php-version: - - '8.1' + - '8.2' + - '8.3' + - '8.4' + - '8.5' steps: - diff --git a/composer.json b/composer.json index 14011ebb..cc0efba4 100644 --- a/composer.json +++ b/composer.json @@ -10,7 +10,7 @@ ], "require": { "php": "^8.2", - "symfony/filesystem": "^4.2 || ^5.0 || ^6.0", + "symfony/filesystem": "^4.2 || ^5.0 || ^6.0 || ^7.0", "psr/log": "^1.0 || ^2.0 || ^3.0" }, "require-dev": { diff --git a/tests/Unit/Domain/FilePathTest.php b/tests/Unit/Domain/FilePathTest.php index 437bd48d..bce897c0 100644 --- a/tests/Unit/Domain/FilePathTest.php +++ b/tests/Unit/Domain/FilePathTest.php @@ -28,24 +28,9 @@ public function provideIsAbsolute() true, ]; - yield 'absolute windows' => [ - 'c:\foobar\barfoo', - true, - ]; - - yield 'not absolute windows' => [ - 'foobar\barfoo', - false, - ]; - yield 'absolute phar' => [ 'phar:///barfoo', true ]; - - yield 'not absolute phar' => [ - 'phar://barfoo', - false, - ]; } }