Skip to content

Commit 456ca22

Browse files
committed
docs: removed outdated contribution instructions
1 parent 5fb736b commit 456ca22

2 files changed

Lines changed: 3 additions & 10 deletions

File tree

docs/source/conf.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -125,6 +125,9 @@ def _anchor_redirects(url, anchors):
125125
'#writing-phpt-tests': _writing_tests_url,
126126
'#basic-format': f'{_writing_tests_url}#minimal-test-layout',
127127
'#analyzing-failing-tests': f'{_writing_tests_url}#analyzing-failures',
128+
'#what-should-i-do-with-my-test-case-when-ive-written-and-tested-it': (
129+
_writing_tests_url
130+
),
128131
'#writing-portable-php-tests': f'{_writing_tests_url}#portability',
129132
},
130133
},

docs/source/testing/writing-tests/index.md

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -182,16 +182,6 @@ shared. If a resource cannot be isolated, declare the narrowest applicable confl
182182
Another good check is to look at what lines of code in the PHP source your test case covers. This is
183183
easy to do, there are some instructions on the [PHP Wiki](https://wiki.php.net/doc/articles/writing-tests).
184184

185-
## What should I do with my test case when I've written and tested it?
186-
187-
The next step is to get someone to review it. If it's short you can paste it into a note and send it
188-
to [php-qa@lists.php.net](mailto:php-qa@lists.php.net). If the test is a bit too long for that then put it somewhere were people
189-
can download it ([pastebin](https://pastebin.com/) is sometimes used). Appending tests to notes as
190-
files doesn't work well - so please don't do that. Your note to [php-qa@lists.php.net](mailto:php-qa@lists.php.net) should say what
191-
level of PHP you have tested it on and what platform(s) you've run it on. Someone from the PHP QA
192-
group will review your test and reply to you. They may ask for some changes or suggest better ways
193-
to do things, or they may commit it to PHP.
194-
195185
## Portability
196186

197187
Writing portable tests can be hard if you don't have access to all the many platforms that PHP can

0 commit comments

Comments
 (0)