From 8a7a02e3184abf026022758e2b39da97b4450fef Mon Sep 17 00:00:00 2001 From: byshy <33957976+byshy@users.noreply.github.com> Date: Wed, 12 Aug 2026 15:22:50 +0400 Subject: [PATCH] fix(pkg): remove trailing quote from Windows ProductVersion rcedit was passed "%APP_VERSION%"", which stamped ProductVersion as e.g. 9.17" on Windows installer builds. Co-authored-by: Cursor --- Make.bat | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Make.bat b/Make.bat index 8d594404ea8..ff3edc5d47d 100644 --- a/Make.bat +++ b/Make.bat @@ -322,7 +322,7 @@ REM Main build sequence Ends %TMPDIR%\rcedit-x64.exe "%BUILDROOT%\runtime\pgAdmin4.exe" --set-icon "%WD%\pkg\win32\Resources\pgAdmin4.ico" %TMPDIR%\rcedit-x64.exe "%BUILDROOT%\runtime\pgAdmin4.exe" --set-version-string "FileDescription" "%APP_NAME%" %TMPDIR%\rcedit-x64.exe "%BUILDROOT%\runtime\pgAdmin4.exe" --set-version-string "ProductName" "%APP_NAME%" - %TMPDIR%\rcedit-x64.exe "%BUILDROOT%\runtime\pgAdmin4.exe" --set-product-version "%APP_VERSION%"" + %TMPDIR%\rcedit-x64.exe "%BUILDROOT%\runtime\pgAdmin4.exe" --set-product-version "%APP_VERSION%" IF NOT "%PGADMIN_WINDOWS_CSC%" == "" ( ECHO Attempting to sign the pgAdmin4.exe...