feat: wire TracingInterceptor, sandbox passthrough, replay-safe time, plugin name#1
Open
praveen5959 wants to merge 4 commits into
Open
feat: wire TracingInterceptor, sandbox passthrough, replay-safe time, plugin name#1praveen5959 wants to merge 4 commits into
praveen5959 wants to merge 4 commits into
Conversation
brianstrauch
reviewed
Jun 9, 2026
brianstrauch
left a comment
brianstrauch
left a comment
There was a problem hiding this comment.
Looks great! I just have a few remaining minor comments:
- To make replay tests as strong as possible, look into setting
max_cached_workflows=0 - Instead of using patterns like
error=str(exc), we recommend creating anApplicationError()with a specific type - The call to
setattr()inSanitizingSpanExporterswallows potential errors
| ] | ||
| dependencies = [ | ||
| "temporalio>=1.7", | ||
| "temporalio>=1.19", |
There was a problem hiding this comment.
Claude is actually suggesting 1.23.0 now, since you're using the interceptors field.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.