From adfa00aba2e1e470f34fde8742cf8996ec64d523 Mon Sep 17 00:00:00 2001 From: vprashar2929 Date: Sat, 30 May 2026 00:32:22 +0530 Subject: [PATCH] fix(pkg/cincinnati): log the correct root CA pool size GetUpdates checked TLSClientConfig.ClientCAs to decide whether to log the root CA subject count, but the client transport only ever populates RootCAs (ClientCAs is a server-side field, never set for this outbound client). The nil check was therefore always true: the log always reported "0 root CA subjects" and the branch reporting the real count was dead. Check RootCAs instead, which also correctly guards the RootCAs.Subjects() dereference in the else branch. Signed-off-by: vprashar2929 --- pkg/cincinnati/cincinnati.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkg/cincinnati/cincinnati.go b/pkg/cincinnati/cincinnati.go index d64d158d54..3dee88624a 100644 --- a/pkg/cincinnati/cincinnati.go +++ b/pkg/cincinnati/cincinnati.go @@ -160,7 +160,7 @@ func (c Client) GetUpdates(ctx context.Context, uri *url.URL, desiredArch, curre } req.Header.Set("Accept", GraphMediaType) if c.transport != nil && c.transport.TLSClientConfig != nil { - if c.transport.TLSClientConfig.ClientCAs == nil { + if c.transport.TLSClientConfig.RootCAs == nil { klog.V(2).Infof("Using a root CA pool with 0 root CA subjects to request updates from %s", uri) } else { //nolint:staticcheck // SA1019: TLSClientConfig.RootCAs.Subjects() is deprecated because