fix: allow const vectors with Object::New overload utilizing node_api_create_object_with_properties

Author: KevinEady

doc/object.md

@@ -75,8 +75,8 @@ Creates a new `Napi::Object` value.
 Napi::Object Napi::Object::New(
       napi_env env,
       napi_value prototypeOrNull,
-      std::vector<napi_value>& propertyNames,
-      std::vector<napi_value>& propertyValues);
+      const std::vector<napi_value>& propertyNames,
+      const std::vector<napi_value>& propertyValues);
 ```
 - `[in] env`: The `napi_env` environment in which to construct the `Napi::Value`
   object.

napi-inl.h

@@ -1644,22 +1644,22 @@ inline Object Object::New(napi_env env) {
 #ifdef NODE_API_EXPERIMENTAL_HAS_CREATE_OBJECT_WITH_PROPERTIES
 inline Object Object::New(napi_env env,
                           napi_value prototypeOrNull,
-                          std::vector<napi_value>& propertyNames,
-                          std::vector<napi_value>& propertyValues) {
+                          const std::vector<napi_value>& propertyNames,
+                          const std::vector<napi_value>& propertyValues) {
   if (propertyNames.size() != propertyValues.size()) {
     NAPI_THROW(
         Napi::Error::New(env, "Mismatch in size of property names and values"),
         Object());
   }
 
   napi_value value;
-  napi_status status =
-      node_api_create_object_with_properties(env,
-                                             prototypeOrNull,
-                                             propertyNames.data(),
-                                             propertyValues.data(),
-                                             propertyNames.size(),
-                                             &value);
+  napi_status status = node_api_create_object_with_properties(
+      env,
+      prototypeOrNull,
+      const_cast<napi_value*>(propertyNames.data()),
+      const_cast<napi_value*>(propertyValues.data()),
+      propertyNames.size(),
+      &value);
 
   NAPI_THROW_IF_FAILED(env, status, Object());
   return Object(env, value);

napi.h

@@ -955,8 +955,8 @@ class Object : public TypeTaggable {
   static Object New(
       napi_env env,                ///< Node-API environment
       napi_value prototypeOrNull,  ///< Prototype (Object) or null / empty Value
-      std::vector<napi_value>& propertyNames,  ///< Property names
-      std::vector<napi_value>& propertyValues  ///< Property values
+      const std::vector<napi_value>& propertyNames,  ///< Property names
+      const std::vector<napi_value>& propertyValues  ///< Property values
   );
 #endif