[http-client-csharp] Url-to-Uri last-contract guard misses management methods and enum values

[live1206]

Describe the bug

The Url-suffix normalization introduced by #11642 correctly includes a last-contract compatibility guard, but that guard does not preserve several shipped Azure management SDK methods and enum values.

A full management regeneration renames existing public Url symbols to Uri, causing ApiCompat failures and source-breaking changes.

Reproduction

Regenerate the Azure SDK for .NET management libraries using:

• Regeneration PR: Failed: Update azure-typespec/http-client-csharp-mgmt version to prerelease 1.0.0-alpha.20260813.3 Azure/azure-sdk-for-net#62087
• Reviewed head: 0f593736b88a60cddba1d53251b53985eb32dbd0
• @typespec/http-client-csharp: 1.0.0-alpha.20260817.7
• Azure.Generator: 1.0.0-alpha.20260817.5
• TypeSpec build: 20260817.2

The previous regeneration used generator packages from 20260812, before #11642 was merged.

Existing methods that are renamed

Package	Existing public API	Regenerated API
Azure.ResourceManager.Network	GetVpnProfilePackageUrl / GetVpnProfilePackageUrlAsync	GetVpnProfilePackageUri / GetVpnProfilePackageUriAsync
Azure.ResourceManager.AppService	GetCallbackUrl / GetCallbackUrlAsync	GetCallbackUri / GetCallbackUriAsync
Azure.ResourceManager.ContainerRegistry.Tasks	GetLogSasUrl / GetLogSasUrlAsync	GetLogSasUri / GetLogSasUriAsync
Azure.ResourceManager.ContainerRegistry.Tasks	GetBuildSourceUploadUrl / GetBuildSourceUploadUrlAsync	GetBuildSourceUploadUri / GetBuildSourceUploadUriAsync

The Container Registry operation is surfaced both through the mockable resource-group wrapper and public extension methods, producing ten changed public method declarations in total across the affected packages.

Network locally reports CP0002 for the removed GetVpnProfilePackageUrl methods.

Existing enum values that are renamed

Package/type	Existing value	Regenerated value
Azure.ResourceManager.SecurityInsights.Models.RestApiPollerRequestPagingKind	NextPageUrl	NextPageUri
Azure.ResourceManager.SecurityInsights.Models.SecurityInsightsEntityType	Url	Uri

Likely cause

#11642 checks ClientProvider.LastContractView.Methods before normalizing operation names. Management resource, mockable-resource, and extension methods are synthesized on wrapper providers, so their shipped method names may not exist on the underlying client provider's last-contract view where normalization occurs.

For enum values, the LastContractView field/property lookup also appears not to resolve the final management enum contract in these cases.

The management NameVisitor is not involved in these failures: its Url logic applies only to model type and property names. The affected methods and enum values use the core generator paths added by #11642.

Expected behavior

If the final public management API contains a matching Url-suffixed method or enum value in the assembly identified by ApiCompatVersion, preserve that shipped name. Apply Url → Uri only to genuinely new operations and enum values.

Please add management coverage for synthesized resource/extension methods and management enum values, in addition to the direct client tests added by #11642.

Related management last-contract issue: #11696.

​- by copilot

[github-actions]

🎯 Issue Triage

The Url-to-Uri normalization guard introduced by #11642 fails to preserve existing public method names and enum values in Azure management SDK packages because synthesized management/extension methods and management enum values are not checked against the LastContractView of the underlying client provider.

Category: Bug
Area: emitter:client:csharp

🔍 Analysis

Affected components: @typespec/http-client-csharp — specifically the LastContractView compatibility guard added in #11642.

Root cause: The guard checks ClientProvider.LastContractView.Methods for operation name preservation, but management resource methods, mockable-resource wrapper methods, and extension methods are synthesized on wrapper providers — their names are not present on the underlying client provider's last-contract view. Similarly, the LastContractView field/property lookup does not resolve management enum contracts, so enum values like NextPageUrl and Url are also renamed.

Impact: ApiCompat (CP0002) failures and source-breaking renames across several Azure SDK for .NET management packages (Network, AppService, ContainerRegistry.Tasks, SecurityInsights).

Related issues: #11696 (management last-contract), #11642 (original Url→Uri normalization PR).

📝 Suggested next steps

• Extend the LastContractView guard to cover synthesized management resource/mockable-resource/extension methods
• Extend the LastContractView enum value lookup to resolve management enum contracts
• Add management-specific test coverage for these scenarios (as noted in the expected behavior section)

Generated by Agentic Triage

[JoshLove-msft]

Management emitter follow-up

PR #11718 adds the shared ClientProvider prerequisite, but the management emitter still needs to supply the final public provider whose last-contract surface owns each synthesized method.

Synthesized operation methods

Azure.Generator.Management.Utilities.ClientProviderExtensions.GetConvenienceMethodByOperation currently calls:

clientProvider.GetMethodCollectionByOperation(operation, clientProvider)

That always performs compatibility lookup against the underlying REST client. It should accept a TypeProvider backCompatProvider and pass the final management provider instead. Propagate that provider through the management operation-method creation paths:

• ResourceClientProvider and ResourceCollectionClientProvider
• MockableResourceProvider
• ExtensionProvider
• ResourceOperationMethodProvider
• PageableOperationMethodProvider
• ArrayResponseOperationMethodProvider / collection-result helpers

The provider passed for lookup must be the type on which the public method is ultimately emitted. This lets #11718 re-clean from InputOperation.OriginalName and find GetVpnProfilePackageUrl, GetCallbackUrl, GetLogSasUrl, and GetBuildSourceUploadUrl in that wrapper's LastContractView. The same REST operation may be projected onto multiple management providers, so lookup must occur with the applicable provider before each synthesized method collection is consumed.

Add management regressions covering resource, mockable-resource, and extension-method projections, including sync and async methods. The tests should verify that an existing ...Url contract is preserved while a genuinely new operation still becomes ...Uri.

Enum members

MTG already contains the preservation logic:

• EnumProvider.GetGeneratedValueName checks last-contract member names before applying Url -> Uri.
• FixedEnumProvider.BuildEnumValuesForBackCompatibility restores fixed-enum fields.
• ExtensibleEnumProvider uses last-contract properties.

The management work is therefore to ensure the management enum provider resolves the final public management enum as its LastContractView before EnumValues are materialized. ManagementTypeFactory.CreateEnumCore currently delegates directly to the base provider. Trace/fix the final generated name, namespace, and declaring type used for last-contract lookup (including any management visitor rename). If necessary, introduce a management enum provider/lookup override that resolves by the final CSharpType; do not duplicate Url -> Uri logic in NameVisitor.

Add regressions without compatibility customizations for:

• extensible RestApiPollerRequestPagingKind.NextPageUrl
• extensible SecurityInsightsEntityType.Url
• a new ...Url enum member that should generate as ...Uri
• a fixed enum equivalent to exercise BuildEnumValuesForBackCompatibility

The existing SecurityInsights CodeGenMember compatibility files should become unnecessary once the correct last-contract enum is resolved.

--generated by Copilot