Optimize packetScoreInt by using only float, not double#2723
Open
toofishes wants to merge 1 commit into
Open
Conversation
On ESP32, this eliminates calls to 9 soft-float operations: __floatsidf, __divdf3, __divsf3, __subdf3, __extendsfdf2, __muldf3, __ledf2, __gedf2, and __truncdfsf2. All operations can now be done in hardware floating point, and the code size is ~100 bytes smaller, as well as likely much faster. Changing to `* 0.1f` rather than `/ 10.0f` allows using hardware floating point multiply, since there is no hardware divide instruction.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On ESP32, this eliminates calls to 9 soft-float operations: __floatsidf, __divdf3, __divsf3, __subdf3, __extendsfdf2, __muldf3, __ledf2, __gedf2, and __truncdfsf2.
All operations can now be done in hardware floating point, and the code size is ~100 bytes smaller, as well as likely much faster.
Changing to
* 0.1frather than/ 10.0fallows using hardware floating point multiply, since there is no hardware divide instruction.