fix(techo-lite): remove duplicate EXTERNAL_FLASH_DEVICES definition#2719
Open
jirogit wants to merge 1 commit into
Open
fix(techo-lite): remove duplicate EXTERNAL_FLASH_DEVICES definition#2719jirogit wants to merge 1 commit into
jirogit wants to merge 1 commit into
Conversation
variant.h defines EXTERNAL_FLASH_DEVICES twice: - First (correct): ZD25WQ32CEIGR (32Mbit = 4MB, matches actual hardware) - Second (incorrect): MX25R1635F (16Mbit = 2MB, T-Echo non-Lite chip) Due to C preprocessor behavior, the second definition silently overrides the first, causing firmware to initialize the wrong flash chip. This can result in LittleFS operating incorrectly on T-Echo Lite hardware. Remove the erroneous second definition. Also fix missing newline at end of file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
variants/lilygo_techo_lite/variant.hdefinesEXTERNAL_FLASH_DEVICEStwice:Due to C preprocessor behavior, the second definition silently overrides the first.
As a result, firmware initializes
MX25R1635F(2MB) instead of the actualZD25WQ32CEIGR(4MB) chip, which can cause LittleFS to operate incorrectlyon T-Echo Lite hardware.
Fix
Remove the erroneous second definition (lines 98–99). The
MX25R1635Fappearsto have been copied from the T-Echo (non-Lite) board definition by mistake.
Also fix missing newline at end of file.
Testing
Built LilyGo_T-Echo-Lite_non_shell_companion_radio_ble Success.