From 8b7987b0e2fd684481a9bfbac6f9e7e588ef07b9 Mon Sep 17 00:00:00 2001 From: Mark Mennell Date: Tue, 11 Aug 2026 07:17:59 +1000 Subject: [PATCH] Test FlagHasPid with != 0, not == 1 Masking with a flag constant then comparing to 1 only works while the flag is bit 0; != 0 is correct for any bit position and matches every other flag check in the codebase. Co-Authored-By: Claude Fable 5 --- cmd/fmsgd/host.go | 2 +- pkg/fmsg/fmsg.go | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/cmd/fmsgd/host.go b/cmd/fmsgd/host.go index 63825fc..3527c38 100644 --- a/cmd/fmsgd/host.go +++ b/cmd/fmsgd/host.go @@ -1018,7 +1018,7 @@ func readHeader(c net.Conn) (*FMsgHeader, *bufio.Reader, error) { } // read pid if any - if flags&FlagHasPid == 1 { + if flags&FlagHasPid != 0 { pid, err := io.ReadAll(io.LimitReader(r, 32)) if err != nil { return h, r, err diff --git a/pkg/fmsg/fmsg.go b/pkg/fmsg/fmsg.go index 69c1ebc..fb489e1 100644 --- a/pkg/fmsg/fmsg.go +++ b/pkg/fmsg/fmsg.go @@ -90,7 +90,7 @@ func (h *Header) Encode() []byte { var b bytes.Buffer b.WriteByte(h.Version) b.WriteByte(h.Flags) - if h.Flags&FlagHasPid == 1 { + if h.Flags&FlagHasPid != 0 { b.Write(h.Pid[:]) } str := h.From.ToString()