Environment
- Android OS version: Any (lower-end devices with smaller growth limits hit it sooner)
- Devices affected: Any. Reproducible when the GeoJSON feature list is sufficiently large (crash observed at ~143 MB allocation attempt with a 201 MB growth limit)
- Maps SDK Version: Confirmed present on main as of the date of this report.
Observed behavior and steps to reproduce
App crashes with OutOfMemoryError when a GeoJsonSourceState is backed by a GeoJSONData(List) containing a large number of features, due to an internal log call.
Steps:
- Create a
GeoJsonSourceState -> sourceState.data = GeoJSONData(listOfFeatures).
- Observe the app crash with the following OOM.
val sourceState = remember(sourceId) {
GeoJsonSourceState(sourceId = sourceId).apply {
...
}
}
LaunchedEffect(features) {
withContext(Dispatchers.Default) {
val finalFeatures = features.map { it.toMapboxFeature() }
sourceState.data = GeoJSONData(finalFeatures)
}
}
sourceState
Stack trace:
java.lang.OutOfMemoryError: Failed to allocate a 143240712 byte allocation with 25165824 free bytes and 49MB until OOM, target footprint 174756928, growth limit 201326592
at java.util.Arrays.copyOf(Arrays.java:3766)
at java.lang.AbstractStringBuilder.ensureCapacityInternal(AbstractStringBuilder.java:125)
at java.lang.AbstractStringBuilder.append(AbstractStringBuilder.java:449)
at java.lang.StringBuilder.append(StringBuilder.java:137)
at java.lang.StringBuilder.append(StringBuilder.java:132)
at java.util.AbstractCollection.toString(AbstractCollection.java:473)
at com.mapbox.maps.extension.compose.style.sources.GeoJSONData.toString(PropertyTypes.kt:335)
at java.lang.String.valueOf(String.java:3657)
at java.lang.StringBuilder.append(StringBuilder.java:132)
at com.mapbox.maps.extension.compose.style.sources.SourceState$launchCollectGeoJsonData$1.invokeSuspend(SourceState.kt:230)
at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.java:34)
at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:100)
at kotlinx.coroutines.internal.LimitedDispatcher$Worker.run(LimitedDispatcher.kt:124)
at kotlinx.coroutines.scheduling.TaskImpl.run(Tasks.kt:89)
at kotlinx.coroutines.scheduling.CoroutineScheduler.runSafely(CoroutineScheduler.kt:586)
at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.execTask(CoroutineScheduler.kt:798)
at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.runWorker(CoroutineScheduler.kt:798)
at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.run(CoroutineScheduler.kt:717)
Suppressed:
kotlinx.coroutines.internal.DiagnosticCoroutineContextException:
[CoroutineName(SourceStateMapboxMapScope_gps_source),
StandaloneCoroutine{Cancelling}@5888d8a,
Dispatchers.IO]
Expected behavior
GeoJsonSourceState should handle large feature collections without crashing. Updating a source with thousands of GPS points is a standard use case. The SDK should not attempt to serialize the full feature list into a single String as a side-effect of a log call.
Notes / preliminary analysis
SourceState.kt:230 — eager toString() in a log statement
// SourceState.kt ~line 228-233
private fun CoroutineScope.launchCollectGeoJsonData(mapboxMap: MapboxMap) =
launch(Dispatchers.IO) {
geoJSONDataChannel.consumeEach { data ->
logD(TAG, "setGeoJsonSourceData: $data") // <-- triggers toString() unconditionally
...
}
}
Additional links and references
SourceState.kt — launchCollectGeoJsonData
(https://github.com/mapbox/mapbox-maps-android/blob/main/extension-compos
e/src/main/java/com/mapbox/maps/extension/compose/style/sources/SourceSta
te.kt)
PropertyTypes.kt — GeoJSONData.toString()
(https://github.com/mapbox/mapbox-maps-android/blob/main/extension-compos
e/src/main/java/com/mapbox/maps/extension/compose/style/sources/PropertyT
ypes.kt)
Environment
Observed behavior and steps to reproduce
App crashes with OutOfMemoryError when a GeoJsonSourceState is backed by a GeoJSONData(List) containing a large number of features, due to an internal log call.
Steps:
GeoJsonSourceState->sourceState.data = GeoJSONData(listOfFeatures).Stack trace:
Expected behavior
GeoJsonSourceState should handle large feature collections without crashing. Updating a source with thousands of GPS points is a standard use case. The SDK should not attempt to serialize the full feature list into a single String as a side-effect of a log call.
Notes / preliminary analysis
SourceState.kt:230 — eager toString() in a log statement
Additional links and references
SourceState.kt — launchCollectGeoJsonData
(https://github.com/mapbox/mapbox-maps-android/blob/main/extension-compos
e/src/main/java/com/mapbox/maps/extension/compose/style/sources/SourceSta
te.kt)
PropertyTypes.kt — GeoJSONData.toString()
(https://github.com/mapbox/mapbox-maps-android/blob/main/extension-compos
e/src/main/java/com/mapbox/maps/extension/compose/style/sources/PropertyT
ypes.kt)