Skip to content

Exceptions opening Analytics Architect #980

Description

@cambot

So far, no one has created any analytics cubes yet in our system. When I opened the architect for the first time, I saw this exception:

Image

Error invoking Source Control: ERROR #5002 ObjectScript error: IsProductionClass+1^SourceControl.Git.Production *(No name)

IsProductionClass() does not have any null input safety checks:

SHCDF>zw $system.CLS.IsMthd("", "%Extends")

ZW $SYSTEM.CLS.IsMthd("", "%Extends")
^
<CLASS DOES NOT EXIST> *(No name)

I would think this function should return 0-false if className is blank:

ClassMethod IsProductionClass(className As %String, nameMethod As %String) As %Boolean
{
    quit:(className = "") 0
	if $system.CLS.IsMthd(className, "%Extends") {
		try {
			return $classmethod(className, "%Extends", "Ens.Production")
		} catch err {
			if '(err.AsStatus() [ "CLASS DOES NOT EXIST") throw err
		}
	} else {

While I was reading the code where this gets called from, I also noticed that Git.Utils.Type() also has weird behavior when it's input is blank:

SHCDF>zw ##class(SourceControl.Git.Utils).Type("")
"csp"

It should probably return "", though I did not analyze the implication of this.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions