You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
1. Incorrect default path for MCP_GATEWAY_WASM_CACHE_DIR in docs/ENVIRONMENT_VARIABLES.md
Location:docs/ENVIRONMENT_VARIABLES.md — MCP_GATEWAY_WASM_CACHE_DIR row Problem: The description says "defaults to <log-dir>/wazero-cache" and the Default column shows /tmp/gh-aw/mcp-logs/wazero-cache, implying the wazero cache is a child of the log directory. Actual Behavior: The code computes the default as filepath.Join(filepath.Dir(logDir), "wazero-cache") — meaning it is a sibling of the log directory, one level up. With the default log dir /tmp/gh-aw/mcp-logs, the wazero cache defaults to /tmp/gh-aw/wazero-cache. Impact: Users configuring volume mounts or filesystem access expecting the cache at /tmp/gh-aw/mcp-logs/wazero-cache will not find it there. Operators watching disk usage in the log directory won't see the cache. Monitoring, cleanup scripts, and Docker volume configurations derived from this documentation will target the wrong path. Suggested Fix: Update the description to "defaults to <parent-of-log-dir>/wazero-cache" and change the Default column from /tmp/gh-aw/mcp-logs/wazero-cache to /tmp/gh-aw/wazero-cache. Code Reference:internal/cmd/wasm_cache.go:17 — return filepath.Join(filepath.Dir(logDir), config.DefaultWasmCacheDirName)
Exact fix for docs/ENVIRONMENT_VARIABLES.md:
| `MCP_GATEWAY_WASM_CACHE_DIR` | Disk-backed wazero compilation cache directory (sets default for `--wasm-cache-dir`; defaults to `<parent-of-log-dir>/wazero-cache`, a sibling of the log directory) | `/tmp/gh-aw/wazero-cache` |
Note:README.md already uses the correct phrasing: "the wazero cache (<parent-of-log-dir>/wazero-cache, a sibling of --log-dir by default)". Only docs/ENVIRONMENT_VARIABLES.md needs updating.
Documentation Completeness
Accurate Sections ✅
README.md Quick Start — Docker run command, config.json structure, --config-stdin requirement, and flag descriptions are all accurate.
CONTRIBUTING.md Make targets — All documented targets (build, test, test-unit, test-integration, test-all, test-race, test-ci, lint, coverage, format, clean, install) exist in the Makefile and descriptions match.
CONTRIBUTING.md Prerequisites — Go version 1.25.0 matches go.mod; Docker requirement is accurate.
CONTRIBUTING.md CLI flags — --config-stdin, --routed, --unified, --listen, --log-dir, --env, --sequential-launch, --payload-dir all verified in internal/cmd/.
docs/CONFIGURATION.md Server Fields — container, entrypoint, entrypointArgs, args, mounts, env, url, connectTimeout, toolTimeout, guard-policies all verified against internal/config/config_stdin.go.
JSON stdin command field — Correctly documented as NOT supported; StdinServerConfig struct has no Command field (confirmed in internal/config/config_stdin.go:83).
Binary name — awmg matches BINARY_NAME in Makefile.
Tested Commands
✅ make build — target exists and correct binary name awmg
✅ make test / make test-unit — alias relationship confirmed in Makefile
✅ make test-integration — auto-builds if binary absent (confirmed in Makefile)
✅ make test-all — rebuilds before running all tests
✅ make test-race — target exists with correct description
✅ make lint — runs go vet, gofmt check, and golangci-lint
✅ make coverage — target exists
✅ make install — installs golangci-lint v2.8.0 and Go deps
⚠️make build — could not execute due to network firewall blocking Go 1.25.0 toolchain download from proxy.golang.org; target is correctly defined.
Recommendations
Immediate Actions Required:
Fix the wazero cache path in docs/ENVIRONMENT_VARIABLES.md (see exact fix above — one-line change).
Summary
Found 1 discrepancy between documentation and implementation during nightly reconciliation check.
Important Issues 🟡
1. Incorrect default path for
MCP_GATEWAY_WASM_CACHE_DIRin docs/ENVIRONMENT_VARIABLES.mdLocation:
docs/ENVIRONMENT_VARIABLES.md—MCP_GATEWAY_WASM_CACHE_DIRrowProblem: The description says "defaults to
<log-dir>/wazero-cache" and the Default column shows/tmp/gh-aw/mcp-logs/wazero-cache, implying the wazero cache is a child of the log directory.Actual Behavior: The code computes the default as
filepath.Join(filepath.Dir(logDir), "wazero-cache")— meaning it is a sibling of the log directory, one level up. With the default log dir/tmp/gh-aw/mcp-logs, the wazero cache defaults to/tmp/gh-aw/wazero-cache.Impact: Users configuring volume mounts or filesystem access expecting the cache at
/tmp/gh-aw/mcp-logs/wazero-cachewill not find it there. Operators watching disk usage in the log directory won't see the cache. Monitoring, cleanup scripts, and Docker volume configurations derived from this documentation will target the wrong path.Suggested Fix: Update the description to "defaults to
<parent-of-log-dir>/wazero-cache" and change the Default column from/tmp/gh-aw/mcp-logs/wazero-cacheto/tmp/gh-aw/wazero-cache.Code Reference:
internal/cmd/wasm_cache.go:17—return filepath.Join(filepath.Dir(logDir), config.DefaultWasmCacheDirName)Exact fix for
docs/ENVIRONMENT_VARIABLES.md:Documentation Completeness
Accurate Sections ✅
--config-stdinrequirement, and flag descriptions are all accurate.<parent-of-log-dir>/wazero-cache).build,test,test-unit,test-integration,test-all,test-race,test-ci,lint,coverage,format,clean,install) exist in the Makefile and descriptions match.1.25.0matchesgo.mod; Docker requirement is accurate.--config-stdin,--routed,--unified,--listen,--log-dir,--env,--sequential-launch,--payload-dirall verified ininternal/cmd/.container,entrypoint,entrypointArgs,args,mounts,env,url,connectTimeout,toolTimeout,guard-policiesall verified againstinternal/config/config_stdin.go.commandfield — Correctly documented as NOT supported;StdinServerConfigstruct has noCommandfield (confirmed ininternal/config/config_stdin.go:83).awmgmatchesBINARY_NAMEin Makefile.Tested Commands
make build— target exists and correct binary nameawmgmake test/make test-unit— alias relationship confirmed in Makefilemake test-integration— auto-builds if binary absent (confirmed in Makefile)make test-all— rebuilds before running all testsmake test-race— target exists with correct descriptionmake lint— runsgo vet,gofmtcheck, andgolangci-lintmake coverage— target existsmake install— installs golangci-lintv2.8.0and Go depsmake build— could not execute due to network firewall blocking Go 1.25.0 toolchain download fromproxy.golang.org; target is correctly defined.Recommendations
Immediate Actions Required:
docs/ENVIRONMENT_VARIABLES.md(see exact fix above — one-line change).Code References
internal/cmd/wasm_cache.go:15-19internal/config/config_core.go:49—/tmp/gh-aw/mcp-logsinternal/config/config_core.go:51—wazero-cachecommandfield):internal/config/config_stdin.go:83-85Warning
Firewall blocked 1 domain
The following domain was blocked by the firewall during workflow execution:
proxy.golang.orgSee Network Configuration for more information.