From 40c55838befd6b5830a324bffb1b8e58843feb66 Mon Sep 17 00:00:00 2001 From: Camille Simon Date: Tue, 28 Jul 2026 10:39:33 -0700 Subject: [PATCH 1/2] add hint about vid recording integration tests --- packages/camera/camera_android_camerax/AGENTS.md | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/camera/camera_android_camerax/AGENTS.md b/packages/camera/camera_android_camerax/AGENTS.md index 084feab8b2b6..34607acb6b19 100644 --- a/packages/camera/camera_android_camerax/AGENTS.md +++ b/packages/camera/camera_android_camerax/AGENTS.md @@ -23,4 +23,5 @@ - Maintain high test coverage using [dart-add-unit-test](.agents/skills/dart-add-unit-test/SKILL.md) and [dart-collect-coverage](.agents/skills/dart-collect-coverage/SKILL.md). - Avoid duplicating constant strings; reuse existing ones from adjacent code. +- **Video Recording Integration Tests**: You MUST insert a delay (e.g., `await Future.delayed(const Duration(seconds: 4));`) after starting a video recording and before stopping it. Without this delay, the test will flake or fail because the Android device/emulator needs time to initialize the encoder and capture frames before finalizing. - **CRITICAL**: When spawning subagents, NEVER provide absolute file paths in prompts. ALWAYS use relative paths. Passing absolute paths breaks `Workspace: branch` isolation and causes state bleed into the active workspace. From 2c1aa30414ba01a5a4bc0dffd4f1a1e86dd66cbf Mon Sep 17 00:00:00 2001 From: Camille Simon Date: Tue, 28 Jul 2026 11:19:31 -0700 Subject: [PATCH 2/2] add TESTING.md and revise AGENTS.md to link to it + add example --- packages/camera/camera_android_camerax/AGENTS.md | 2 +- packages/camera/camera_android_camerax/TESTING.md | 9 +++++++++ 2 files changed, 10 insertions(+), 1 deletion(-) create mode 100644 packages/camera/camera_android_camerax/TESTING.md diff --git a/packages/camera/camera_android_camerax/AGENTS.md b/packages/camera/camera_android_camerax/AGENTS.md index 34607acb6b19..eff2baa79ac4 100644 --- a/packages/camera/camera_android_camerax/AGENTS.md +++ b/packages/camera/camera_android_camerax/AGENTS.md @@ -23,5 +23,5 @@ - Maintain high test coverage using [dart-add-unit-test](.agents/skills/dart-add-unit-test/SKILL.md) and [dart-collect-coverage](.agents/skills/dart-collect-coverage/SKILL.md). - Avoid duplicating constant strings; reuse existing ones from adjacent code. -- **Video Recording Integration Tests**: You MUST insert a delay (e.g., `await Future.delayed(const Duration(seconds: 4));`) after starting a video recording and before stopping it. Without this delay, the test will flake or fail because the Android device/emulator needs time to initialize the encoder and capture frames before finalizing. +- **Testing Guidelines**: You MUST read and follow all rules in [TESTING.md](TESTING.md) BEFORE writing or modifying any tests. This is CRITICAL for preventing CI flakiness. - **CRITICAL**: When spawning subagents, NEVER provide absolute file paths in prompts. ALWAYS use relative paths. Passing absolute paths breaks `Workspace: branch` isolation and causes state bleed into the active workspace. diff --git a/packages/camera/camera_android_camerax/TESTING.md b/packages/camera/camera_android_camerax/TESTING.md new file mode 100644 index 000000000000..bde718852563 --- /dev/null +++ b/packages/camera/camera_android_camerax/TESTING.md @@ -0,0 +1,9 @@ +# Testing Best Practices + +This document outlines testing rules and best practices for the `camera_android_camerax` package. All contributors MUST follow these guidelines to prevent CI flakiness and maintain code quality. + +## Integration Tests + +- **Video Recording Delay**: You MUST add a delay of at least 4 seconds (e.g., `await Future.delayed(const Duration(seconds: 4));`) before stopping a video recording. + - *Why*: Both physical Android devices and emulators require time for the CameraX encoder to initialize and capture actual video frames. Stopping immediately will result in an empty or corrupted file, causing CI flakes. + - *Example*: See the `video recording state is cleared after camera is disposed` test in [`example/integration_test/integration_test.dart`](example/integration_test/integration_test.dart).