fix(tests): pytest 9 + xdist compat (subTest serialization)

Three independent fixes surfaced by the dep bump's pytest 7 → 9 jump:

1) pytest 9 + xdist 3.8 serializes subTest parametrization across worker
   process boundaries via execnet. Class objects (thrift response types)
   and thrift instances are not pickleable through execnet's restricted
   serializer. Replace them with string labels:

   - tests/unit/test_thrift_backend.py:
     * resp_type / exec_resp_type → resp_type.__name__
     * op_state_resp thrift instance → ("error_resp"/"closed_resp", inst) tuple
     * error_resp thrift instance → f"resp_{i}" index label
   - tests/unit/test_endpoint.py:
     * CloudType enum → .value

   Net effect: every subTest now passes only str/int/None to the subTest
   keyword args. Test coverage is unchanged — the labels still uniquely
   identify which subtest failed.

2) urllib3 2.x adds a `version_string` attribute that retry handlers
   read off the response object. tests/e2e/common/retry_test_mixins.py's
   SimpleHttpResponse mock missed this attribute; add it.

3) pyjwt 2.13.0's stricter type signatures expose a pre-existing mypy
   `Incompatible return value type` warning in oauth.py — `exp_time and
   (exp_time - buffer_time) <= current_time` returns Any|None, not bool.
   Wrap exp_time in bool() to satisfy mypy without changing semantics
   (None and False are both falsy; result is identical for all inputs).

Also updates poetry.lock for the pytest line (`^8.4.0` -> `^9.0.3`
restoration; intermediate downgrade was an investigation step, now
reverted).

Local verification on Python 3.10.18:
  poetry run pytest tests/unit/ -n auto   765 passed, 4 skipped
  ~/osv-scanner scan source --lockfile poetry.lock   No issues found

Co-authored-by: Isaac
Signed-off-by: Vikrant Puppala <vikrant.puppala@databricks.com>

Author: vikrantpuppala

src/databricks/sql/auth/oauth.py

@@ -45,7 +45,7 @@ def is_expired(self) -> bool:
             exp_time = decoded_token.get("exp")
             current_time = time.time()
             buffer_time = 30  # 30 seconds buffer
-            return exp_time and (exp_time - buffer_time) <= current_time
+            return bool(exp_time) and (exp_time - buffer_time) <= current_time
         except Exception as e:
             logger.error("Failed to decode token: %s", e)
             raise e

tests/e2e/common/retry_test_mixins.py

@@ -202,8 +202,8 @@ def __init__(self, status: int, headers: dict, redirect_location: Optional[str]
         self.reason = "Mocked Response"
         self.version = 11
         # urllib3 >= 2.3 reads `version_string` off the raw httplib response in
-        # HTTPConnectionPool._make_request. Older urllib3 (incl. the 2.2.x pinned
-        # in CI) never touches it, so this is a harmless forward-compat shim.
+        # HTTPConnectionPool._make_request. 5.0.0 pins urllib3 >= 2.7, so this
+        # attribute is always read; the shim keeps the mock response compatible.
         self.version_string = "HTTP/1.1"
         self.length = 0
         self.length_remaining = 0

tests/unit/test_endpoint.py

@@ -27,7 +27,10 @@ def test_infer_cloud_from_host(self):
         ]
 
         for expected_type, host in param_list:
-            with self.subTest(expected_type or "None", expected_type=expected_type):
+            with self.subTest(
+                expected_type.value if expected_type else "None",
+                expected_type=expected_type.value if expected_type else None,
+            ):
                 self.assertEqual(infer_cloud_from_host(host), expected_type)
                 self.assertEqual(
                     infer_cloud_from_host(f"https://{host}/to/path"), expected_type
@@ -97,7 +100,7 @@ def test_oauth_endpoint(self):
             expected_scopes,
             expected_scope2,
         ) in param_list:
-            with self.subTest(cloud_type):
+            with self.subTest(cloud_type.value):
                 endpoint = get_oauth_endpoints(host, use_azure_auth)
                 self.assertEqual(
                     endpoint.get_authorization_url(host), expected_auth_url

tests/unit/test_thrift_backend.py

@@ -596,7 +596,7 @@ def test_make_request_checks_status_code(self):
 
     def test_handle_execute_response_checks_operation_state_in_direct_results(self):
         for resp_type in self.execute_response_types:
-            with self.subTest(resp_type=resp_type):
+            with self.subTest(resp_type=resp_type.__name__):
                 t_execute_resp = resp_type(
                     status=self.okay_status,
                     directResults=ttypes.TSparkDirectResults(
@@ -779,10 +779,12 @@ def test_handle_execute_response_checks_operation_state_in_polls(
         )
 
         for op_state_resp, exec_resp_type in itertools.product(
-            [error_resp, closed_resp], self.execute_response_types
+            [("error_resp", error_resp), ("closed_resp", closed_resp)],
+            self.execute_response_types,
         ):
+            op_state_label, op_state_resp = op_state_resp
             with self.subTest(
-                op_state_resp=op_state_resp, exec_resp_type=exec_resp_type
+                op_state_resp=op_state_label, exec_resp_type=exec_resp_type.__name__
             ):
                 tcli_service_instance = tcli_service_class.return_value
                 t_execute_resp = exec_resp_type(
@@ -942,8 +944,10 @@ def test_handle_execute_response_checks_direct_results_for_error_statuses(self):
                 operationHandle=self.operation_handle,
             )
 
-            for error_resp in [resp_1, resp_2, resp_3, resp_4]:
-                with self.subTest(error_resp=error_resp):
+            for resp_idx, error_resp in enumerate(
+                [resp_1, resp_2, resp_3, resp_4], start=1
+            ):
+                with self.subTest(error_resp=f"resp_{resp_idx}"):
                     thrift_backend = ThriftDatabricksClient(
                         "foobar",
                         443,
@@ -966,7 +970,7 @@ def test_handle_execute_response_can_handle_without_direct_results(
         tcli_service_instance = tcli_service_class.return_value
 
         for resp_type in self.execute_response_types:
-            with self.subTest(resp_type=resp_type):
+            with self.subTest(resp_type=resp_type.__name__):
 
                 execute_resp = resp_type(
                     status=self.okay_status,
@@ -1029,7 +1033,7 @@ def test_handle_execute_response_can_handle_with_direct_results(self):
         )
 
         for resp_type in self.execute_response_types:
-            with self.subTest(resp_type=resp_type):
+            with self.subTest(resp_type=resp_type.__name__):
                 execute_resp = resp_type(
                     status=self.okay_status,
                     directResults=direct_results_message,
@@ -1134,7 +1138,7 @@ def test_handle_execute_response_reads_has_more_rows_in_direct_results(
         for has_more_rows, resp_type in itertools.product(
             [True, False], self.execute_response_types
         ):
-            with self.subTest(has_more_rows=has_more_rows, resp_type=resp_type):
+            with self.subTest(has_more_rows=has_more_rows, resp_type=resp_type.__name__):
                 tcli_service_instance = tcli_service_class.return_value
                 results_mock = Mock()
                 results_mock.startRowOffset = 0
@@ -1180,7 +1184,7 @@ def test_handle_execute_response_reads_has_more_rows_in_result_response(
         for has_more_rows, resp_type in itertools.product(
             [True, False], self.execute_response_types
         ):
-            with self.subTest(has_more_rows=has_more_rows, resp_type=resp_type):
+            with self.subTest(has_more_rows=has_more_rows, resp_type=resp_type.__name__):
                 tcli_service_instance = tcli_service_class.return_value
                 results_mock = MagicMock()
                 results_mock.startRowOffset = 0