From 67c258962fcbb87bf77253ac7e166ffb03a83a0e Mon Sep 17 00:00:00 2001 From: Grigory Panov Date: Fri, 17 Jul 2026 15:27:22 +0200 Subject: [PATCH] Fix serverless default test assertions to use EnvKeyForServerless The two default-serverless tests built the expected env key by string concatenation ('serverless/serverless-'+defaultServerlessVersion). That held only while the constant was 'v5'; once it became the bare '5' the expectation drifted to serverless-5 while the real key stays serverless-v5 (EnvKeyForServerless normalizes to vN). Assert against EnvKeyForServerless so the test tracks the actual normalization instead of assuming the constant's spelling. Co-authored-by: Isaac --- libs/localenv/target_test.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libs/localenv/target_test.go b/libs/localenv/target_test.go index 3c64d15462..bf03af40eb 100644 --- a/libs/localenv/target_test.go +++ b/libs/localenv/target_test.go @@ -97,7 +97,7 @@ func TestResolveBundleServerless(t *testing.T) { ti, err := ResolveTarget(t.Context(), TargetFlags{}, stubCompute{}, BundleTarget{Selected: true, Serverless: true}) require.NoError(t, err) assert.Equal(t, "bundle", ti.Source) - assert.Equal(t, "serverless/serverless-"+defaultServerlessVersion, ti.EnvKey) + assert.Equal(t, EnvKeyForServerless(defaultServerlessVersion), ti.EnvKey) } // jobStubCompute returns distinct values for the first (sparkVersion) and third @@ -150,7 +150,7 @@ func TestResolveJobServerlessEmptyVersionFallsBackToDefault(t *testing.T) { c := jobStubCompute{isServerless: true, version: ""} ti, err := ResolveTarget(t.Context(), TargetFlags{Job: "42"}, c, BundleTarget{}) require.NoError(t, err) - assert.Equal(t, "serverless/serverless-"+defaultServerlessVersion, ti.EnvKey) + assert.Equal(t, EnvKeyForServerless(defaultServerlessVersion), ti.EnvKey) } func TestValidateTargetFlagsMutuallyExclusive(t *testing.T) {