fix: release wake-up connections when shutdown fails

Cleanup ran after component shutdown, so a component raising in stop skipped it and left listener connections open. Move the release into an ensure so a failed shutdown cannot leak connections held outside the pool.

Author: cardmagic

lib/solid_objects/supervisor.rb

@@ -44,12 +44,17 @@ def start
     def stop
       return unless @started
 
-      components.each(&:request_shutdown)
-      join_until_timeout
-      components.reject(&:stopped?).each(&:stop)
-      release_wake_up
-      @started = false
-      SolidObjects.instrument(:"supervisor.stopped", component_count: components.length)
+      begin
+        components.each(&:request_shutdown)
+        join_until_timeout
+        components.reject(&:stopped?).each(&:stop)
+      ensure
+        # Connections held outside the pool must be released even when a
+        # component fails to stop, or they accumulate across restarts.
+        release_wake_up
+        @started = false
+        SolidObjects.instrument(:"supervisor.stopped", component_count: components.length)
+      end
     end
 
     private

test/integration/postgresql_wake_up_test.rb

@@ -103,6 +103,31 @@ class PostgresqlWakeUpTest < ActiveSupport::TestCase
     SolidObjects.instance_variable_set(:@wake_up, nil)
   end
 
+  test "a failing component shutdown still releases listener connections" do
+    SolidObjects.configuration.wake_up_adapter = @adapter
+    SolidObjects.instance_variable_set(:@wake_up, nil)
+    @adapter.listen
+    supervisor = SolidObjects::Supervisor.new(
+      worker_count: 1,
+      effect_worker_count: 0,
+      broadcast_worker_count: 0,
+      reminder_scheduler_count: 0
+    )
+    supervisor.start
+    supervisor.send(:components).each do |component|
+      component.define_singleton_method(:stop) { raise "boom" }
+      component.define_singleton_method(:stopped?) { false }
+    end
+
+    assert_raises(RuntimeError) { supervisor.stop }
+
+    refute @adapter.send(:connections).any?,
+      "a failed shutdown must still release connections opened outside the pool"
+  ensure
+    SolidObjects.configuration.wake_up_adapter = nil
+    SolidObjects.instance_variable_set(:@wake_up, nil)
+  end
+
   test "the helper selects notifications on PostgreSQL" do
     assert_instance_of(
       SolidObjects::WakeUpAdapters::Postgresql,