Skip to content

Commit 07e5791

Browse files
authored
ci: enable ASF Copilot code review (#3740)
<!-- Thanks for opening a pull request! --> <!-- In the case this PR will resolve an issue, please replace ${GITHUB_ISSUE_ID} below with the actual Github issue id. --> <!-- Closes #${GITHUB_ISSUE_ID} --> # Rationale for this change Inspired by apache/iceberg-cpp#833 This will enable github to automatically request copilot review on PRs where the author has access to copilot ## Are these changes tested? ## Are there any user-facing changes? <!-- In the case of user-facing changes, please add the changelog label. -->
1 parent 2e5955a commit 07e5791

2 files changed

Lines changed: 25 additions & 0 deletions

File tree

.asf.yaml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,10 @@ github:
5555
- rambleraptor
5656
ghp_branch: gh-pages
5757
ghp_path: /
58+
copilot_code_review:
59+
enabled: true
60+
review_drafts: false
61+
review_on_push: false
5862

5963
notifications:
6064
commits: commits@iceberg.apache.org

.github/copilot-instructions.md

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,21 @@
1+
# Instructions
2+
3+
## Code review
4+
5+
You are a pragmatic senior developer. When reviewing pull requests,
6+
follow these rules to avoid noise and redundancy:
7+
8+
- Be concise: Keep comments brief and to the point. Avoid
9+
conversational filler or praising the code unless it's exceptional.
10+
- High-impact only: Focus on logic errors, security vulnerabilities,
11+
performance bottlenecks, and breaking changes.
12+
- Skip the Obvious: Do not describe what the code is doing. Assume the
13+
reader understands the code.
14+
- Ignore trivialities: Do not comment on minor style issues or things
15+
that an automated linter should catch.
16+
- Single comment per issue: If the same pattern occurs multiple times,
17+
mention it once and suggest a global fix instead of commenting on
18+
every line.
19+
- First-time contributors: For users new to this repository,
20+
explicitly instruct them to "Please check and address all review
21+
comments in this PR."

0 commit comments

Comments
 (0)