CLOUDSTACK-10357: Improve log messages in methods (#2580)

Fix several logs that mismatch method.
Add stacktraces for throw new statements.

Author: lzh3636

agent/src/main/java/com/cloud/agent/resource/consoleproxy/ConsoleProxyResource.java

@@ -246,7 +246,7 @@ public boolean configure(String name, Map<String, Object> params) throws Configu
                 }
                 String internalDns1 = (String) params.get("internaldns1");
                 if (internalDns1 == null) {
-                    s_logger.warn("No DNS entry found during configuration of NfsSecondaryStorage");
+                    s_logger.warn("No DNS entry found during configuration of ConsoleProxy");
                 } else {
                     addRouteToInternalIpOrCidr(_localgw, _eth1ip, _eth1mask, internalDns1);
                 }

engine/schema/src/main/java/com/cloud/vm/dao/UserVmDaoImpl.java

@@ -410,7 +410,7 @@ public List<Long> listPodIdsHavingVmsforAccount(long zoneId, long accountId) {
             }
             catch (Exception e)
             {
-                s_logger.error("listVmDetails:Exception:" + e.getMessage());
+                s_logger.error("listPodIdsHavingVmsforAccount:Exception:" + e.getMessage());
             }
         }
 

plugins/dedicated-resources/src/main/java/org/apache/cloudstack/dedicated/DedicatedResourceManagerImpl.java

@@ -497,8 +497,8 @@ public List<DedicatedResourceVO> doInTransaction(TransactionStatus status) {
                     }
                     dedicatedResource = _dedicatedDao.persist(dedicatedResource);
                 } catch (Exception e) {
-                    s_logger.error("Unable to dedicate host due to " + e.getMessage(), e);
-                    throw new CloudRuntimeException("Failed to dedicate cluster. Please contact Cloud Support.");
+                    s_logger.error("Unable to dedicate cluster due to " + e.getMessage(), e);
+                    throw new CloudRuntimeException("Failed to dedicate cluster. Please contact Cloud Support.", e);
                 }
 
                 List<DedicatedResourceVO> result = new ArrayList<DedicatedResourceVO>();
@@ -595,7 +595,7 @@ public List<DedicatedResourceVO> doInTransaction(TransactionStatus status) {
                     dedicatedResource = _dedicatedDao.persist(dedicatedResource);
                 } catch (Exception e) {
                     s_logger.error("Unable to dedicate host due to " + e.getMessage(), e);
-                    throw new CloudRuntimeException("Failed to dedicate host. Please contact Cloud Support.");
+                    throw new CloudRuntimeException("Failed to dedicate host. Please contact Cloud Support.", e);
                 }
 
                 List<DedicatedResourceVO> result = new ArrayList<DedicatedResourceVO>();

plugins/hypervisors/baremetal/src/main/java/org/apache/cloudstack/api/DeleteBaremetalRctCmd.java

@@ -64,8 +64,8 @@ public void execute() throws ResourceUnavailableException, InsufficientCapacityE
             SuccessResponse response = new SuccessResponse(getCommandName());
             setResponseObject(response);
         } catch (Exception e) {
-            s_logger.warn(String.format("unable to add baremetal RCT[%s]", getId()), e);
-            throw new ServerApiException(ApiErrorCode.INTERNAL_ERROR, e.getMessage());
+            s_logger.warn(String.format("unable to delete baremetal RCT[%s]", getId()), e);
+            throw new ServerApiException(ApiErrorCode.INTERNAL_ERROR, e.getMessage(), e);
         }
     }
 

plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java

@@ -1309,10 +1309,10 @@ public Answer dettachVolume(final DettachCommand cmd) {
 
             return new DettachAnswer(disk);
         } catch (final LibvirtException e) {
-            s_logger.debug("Failed to attach volume: " + vol.getPath() + ", due to ", e);
+            s_logger.debug("Failed to detach volume: " + vol.getPath() + ", due to ", e);
             return new DettachAnswer(e.toString());
         } catch (final InternalErrorException e) {
-            s_logger.debug("Failed to attach volume: " + vol.getPath() + ", due to ", e);
+            s_logger.debug("Failed to detach volume: " + vol.getPath() + ", due to ", e);
             return new DettachAnswer(e.toString());
         }
     }

plugins/integrations/cloudian/src/main/java/org/apache/cloudstack/cloudian/client/CloudianClient.java

@@ -324,7 +324,7 @@ public boolean updateGroup(final CloudianGroup group) {
             final HttpResponse response = post("/group", group);
             return response.getStatusLine().getStatusCode() == HttpStatus.SC_OK;
         } catch (final IOException e) {
-            LOG.error("Failed to remove group due to:", e);
+            LOG.error("Failed to update group due to:", e);
             checkResponseTimeOut(e);
         }
         return false;

plugins/network-elements/netscaler/src/main/java/com/cloud/network/resource/NetScalerControlCenterResource.java

@@ -785,7 +785,7 @@ public static String getHttpRequest(final String jsonCmd, final URI agentUri, St
         // use Apache.
         String logMessage = StringEscapeUtils.unescapeJava(jsonCmd);
         logMessage = cleanPassword(logMessage);
-        s_logger.debug("POST request to " + agentUri.toString()
+        s_logger.debug("GET request to " + agentUri.toString()
                 + " with contents " + logMessage);
 
         // Create request

plugins/network-elements/nuage-vsp/src/main/java/com/cloud/network/resource/NuageVspResource.java

@@ -189,7 +189,7 @@ public boolean stop() {
         try {
             JmxUtil.unregisterMBean("NuageVspResource", _name);
         } catch (Exception e) {
-            s_logger.warn("Unable to initialize inaccurate clock", e);
+            s_logger.warn("Unable to stop NuageVspResource", e);
         }
 
         return true;

server/src/main/java/com/cloud/network/NetworkModelImpl.java

@@ -1731,7 +1731,7 @@ public String getDefaultGuestTrafficLabel(long dcId, HypervisorType hypervisorTy
             }
         } catch (Exception ex) {
             if (s_logger.isDebugEnabled()) {
-                s_logger.debug("Failed to retrive the default label for management traffic:" + "zone: " + dcId + " hypervisor: " + hypervisorType + " due to:" +
+                s_logger.debug("Failed to retrive the default label for guest traffic:" + "zone: " + dcId + " hypervisor: " + hypervisorType + " due to:" +
                     ex.getMessage());
             }
         }

server/src/main/java/com/cloud/network/as/AutoScaleManagerImpl.java

@@ -1482,7 +1482,7 @@ public void doScaleUp(long groupId, Integer numVm) {
     public void doScaleDown(final long groupId) {
         AutoScaleVmGroupVO asGroup = _autoScaleVmGroupDao.findById(groupId);
         if (asGroup == null) {
-            s_logger.error("Can not find the groupid " + groupId + " for scaling up");
+            s_logger.error("Can not find the groupid " + groupId + " for scaling down");
             return;
         }
         if (!checkConditionDown(asGroup)) {