Commit 5c7aba4
committed
build: load every compiled schematic before publishing
The load failure fixed in the previous commit reached a published release
because nothing in the build or the test suite ever loads what actually ships.
The jasmine suite runs against the TypeScript output, which is a different
module format from the CommonJS bundle in the package, so a bundle can be
completely unloadable while every test passes.
Requiring each compiled entry point at the end of the schematics build closes
that gap. Reverting the previous commit now fails the build with the real
error:
Compiled schematics failed to load:
deploy/actions.js: TypeError [ERR_INVALID_ARG_TYPE] ...
deploy/builder.js: TypeError [ERR_INVALID_ARG_TYPE] ...
It catches the whole class, not just this instance: an unresolvable import, a
bad top-level require, or anything else that throws at module load.1 parent 4bc59ef commit 5c7aba4
1 file changed
Lines changed: 29 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
357 | 357 | | |
358 | 358 | | |
359 | 359 | | |
| 360 | + | |
| 361 | + | |
| 362 | + | |
| 363 | + | |
| 364 | + | |
| 365 | + | |
| 366 | + | |
| 367 | + | |
| 368 | + | |
| 369 | + | |
| 370 | + | |
| 371 | + | |
| 372 | + | |
| 373 | + | |
| 374 | + | |
| 375 | + | |
| 376 | + | |
| 377 | + | |
| 378 | + | |
| 379 | + | |
| 380 | + | |
| 381 | + | |
| 382 | + | |
| 383 | + | |
| 384 | + | |
| 385 | + | |
| 386 | + | |
| 387 | + | |
| 388 | + | |
360 | 389 | | |
361 | 390 | | |
362 | 391 | | |
| |||
0 commit comments