From 727fc9ce148d2041bb824eb52ac3a9696f3b31ab Mon Sep 17 00:00:00 2001 From: TheMeinerLP Date: Mon, 13 Jul 2026 21:53:29 +0200 Subject: [PATCH] fix: use inline x-release-please-version annotation MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The generic extra-files updater needs the annotation as a trailing inline comment on the version line itself, not a leading comment above it — confirmed against OneLiteFeatherNET/PlayerKits' actually- working config. The leading-comment form silently didn't bump gradle.properties in the open release PR (#75, stuck at 1.4.7 while the manifest/tag moved to 1.4.8). Java .properties syntax only treats '#' as a comment marker at the start of a line, so the inline annotation becomes part of the raw version string ("1.4.7 # x-release-please-version"). Strip it back off in build.gradle.kts before Gradle uses the version anywhere, same substringBefore('#') pattern PlayerKits uses. --- build.gradle.kts | 6 ++++++ gradle.properties | 3 +-- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/build.gradle.kts b/build.gradle.kts index b33b0d7..56fa944 100644 --- a/build.gradle.kts +++ b/build.gradle.kts @@ -4,6 +4,12 @@ plugins { alias(libs.plugins.shadow) } +// gradle.properties carries the version as `1.4.7 # x-release-please-version` - the trailing +// comment is release-please's generic-updater annotation, needed inline on the value line for +// it to bump this file. `#` mid-line isn't a real Properties comment, so it's part of the raw +// value; strip it back off here before Gradle uses it anywhere. +version = (version as String).substringBefore('#').trim() + dependencies { implementation(libs.nio.spi.s3) compileOnly(libs.bluemap.core) diff --git a/gradle.properties b/gradle.properties index bf6c1d3..ab79fd1 100644 --- a/gradle.properties +++ b/gradle.properties @@ -1,3 +1,2 @@ -# x-release-please-version -version = 1.4.7 +version = 1.4.7 # x-release-please-version group = dev.themeinerlp