Review finding 16/19 · conventional-comment issue · area binder · gate: follow-up
To add once it exists: label binder. (Already applied: bug.)
Problem
FirstClassErrors.RequestBinder.csproj hardcodes <PackageReleaseNotes>Initial preview release of the FirstClassErrors request binder.</PackageReleaseNotes>.
Impact
Every future release of the package ships these stale notes unless the line is remembered and edited by hand each time — the kind of drift the release tooling exists to prevent.
Direction
Either drop PackageReleaseNotes (let the changelog / release notes be the source of truth) or generate it from the release pipeline, consistent with how the lib train produces notes (tools/packaging/release-notes.sh).
Context
Surfaced by the RequestBinder review (design spec #126, shipped in #141). Finding 16 of 19.
Problem
FirstClassErrors.RequestBinder.csprojhardcodes<PackageReleaseNotes>Initial preview release of the FirstClassErrors request binder.</PackageReleaseNotes>.Impact
Every future release of the package ships these stale notes unless the line is remembered and edited by hand each time — the kind of drift the release tooling exists to prevent.
Direction
Either drop
PackageReleaseNotes(let the changelog / release notes be the source of truth) or generate it from the release pipeline, consistent with how the lib train produces notes (tools/packaging/release-notes.sh).Context
Surfaced by the RequestBinder review (design spec #126, shipped in #141). Finding 16 of 19.